Skip to content

Fix incorrect labelling for "IS NULL" and "IS NOT NULL" clauses in Date Picker #50566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix incorrect labelling for "IS NULL" and "IS NOT NULL" clauses in Date Picker #50566

wants to merge 1 commit into from

Conversation

ttanay
Copy link

@ttanay ttanay commented Nov 27, 2024 •
edited
Loading

Description

On the Query Builder UI for a question, when adding filter on a Date column, adding an "Is empty" filter actually added a "IS NOT NULL" to the query and vice-versa for "Is not empty".
This change fixes it.

How to verify

Describe the steps to verify that the changes are working as expected.

  1. New question -> Sample Dataset -> Select date column -> Click on "Exclude" -> Select "Is empty"
  2. Verify SQL has correct generated clause

Checklist

  • Tests have been added/updated to cover changes in this PR

@ttanay
Interchange operator associated with string to check if empty
37c1ab2 
On the Query Builder UI for a question, when adding filter on a Date
column, adding an "Is empty" filter actually added a "IS NOT NULL"
to the query and vice-versa for "Is not empty".
This change fixes it.
@ttanay ttanay changed the title Interchange operator associated with string to check if date is empty Fix incorrect labelling for "IS NULL" and "IS NOT NULL" clauses in Date Picker Nov 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has had no activity for 90 days, it will be closed in 2 weeks if no further activity occurs.

@github-actions github-actions bot added the Stale Stale PRs that will be auto-closed label Feb 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request was closed because it had no activity for more than 90 days.

@github-actions github-actions bot closed this Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Stale Stale PRs that will be auto-closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ttanay