Add altitude attribute to Marker and Popup #13335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepankuzmin
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Thanks @yangtanyu for this valuable contribution! Adding altitude support for Markers and Popups is a great feature that will enable better 3D visualization capabilities.
The implementation looks good overall. While there are some minor nits, I'll go ahead and merge this now to speed up the process. We'll address improvements as the follow-up work on this feature.
This feature be included in the upcoming GL JS v3.11.0-beta.1. Really appreciate your contribution! 👍
|
You're welcome @stepankuzmin . I'm really glad to contribute to the development of this project. |
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added a new property to Marker and Popup that represents the height above the ground. This is very useful for rendering 3D models and marking objects with specific heights. I hope to contribute to the open-source community.
Please read the instructions and review the code, thanks！
Add additional detail and context in the PR description (with screenshots/videos if there are visual changes).
before:
after:
Manually test the debug page.
I used npm run start debug and added a markers-altitude.html debugging page
Write tests for all new functionality and make sure the CI checks pass.
I used npm run test and it passed the test
Document any changes to public APIs.
/src/ui/marker.ts -> line:58
/src/ui/popup.ts -> line:80
this PR includes style spec API or visual changes.
@mapbox/static-apis @mapbox/map-design-team
Launch Checklist
@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes.@mapbox/gl-nativeif this PR includes shader changes or needs a native port.