Skip to content

Get room inbox notifications #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Get room inbox notifications #2059

wants to merge 5 commits into from

Conversation

FlowFlorent
Copy link
Contributor

@FlowFlorent FlowFlorent commented Nov 12, 2024 •
edited
Loading

Description

This PR introduces two hooks that are available inside our RoomProvider

  • useRoomInboxNotifications
  • useRoomUnreadInboxNotifications ( coming soon ™)

and their associated client methods:

  • room.getRoomInboxNotifications
  • room.getRoomUnreadInboxNotifications

They exhibit the same behaviour as the project level methods, just filtered to a room

Still todo:

  • Look into reacting to some websocket events
  • Tests

FlowFlorent
FlowFlorent commented Nov 12, 2024
View reviewed changes
packages/liveblocks-react/src/umbrella-store.ts
return {
isLoading: false,
// FIXME: The filtering part doesn't look right, should I created a notificationsDB like threadsDB?
inboxNotifications: this.getFullState().cleanedNotifications.filter(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filtering part doesn't look right, should I create a notificationsDB like threadsDB?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvie nvie Awaiting requested review from nvie nvie will be requested when the pull request is marked ready for review nvie is a code owner

@SugarDarius SugarDarius Awaiting requested review from SugarDarius SugarDarius will be requested when the pull request is marked ready for review SugarDarius is a code owner

@marcbouchenoire marcbouchenoire Awaiting requested review from marcbouchenoire marcbouchenoire will be requested when the pull request is marked ready for review marcbouchenoire is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FlowFlorent