Skip to content

Call resolveMentionSuggestions earlier #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Call resolveMentionSuggestions earlier #1876

wants to merge 22 commits into from

Conversation

marcbouchenoire
Copy link
Contributor

@marcbouchenoire marcbouchenoire commented Aug 12, 2024 •
edited
Loading

Based on #1864

marcbouchenoire and others added 22 commits July 30, 2024 10:00
@marcbouchenoire
Don’t disable composer if self isn’t available
b194473
@marcbouchenoire
Stop event propagation on all interactive elements
50732f3
@marcbouchenoire
Handle all parts of composers when disabling them
4bdcb98
@marcbouchenoire
Replace useSelf with useCurrentUserId when possible
af8e622
@marcbouchenoire
Don’t mark threads as read if not in room
b04f836
@GuillaumeSalles
Expose authManager as internal API
26e6c63
@GuillaumeSalles
Remove authManager from client internals and expose getThreads
3abf2ed
Bump to 2.4.1-test1
58a9d27
@marcbouchenoire
Update CHANGELOG.md
7c9b1ba
@GuillaumeSalles
experimental_useUserThreads
85b1723
Bump to 2.4.1-test2
1ebb998
@GuillaumeSalles
Fix waitUntilUserThreadsLoaded
7adb5c4
@GuillaumeSalles
Merge branch 'various-comments-fixes' of github.com:liveblocks/livebl…
85fe0d3 
…ocks into various-comments-fixes
Bump to 2.4.1-test3
2cf1cad
@GuillaumeSalles
Remove unused import
b01dc04
@GuillaumeSalles
- Fix rules of hooks and typing for new experimental useUserThreads
504e1e5 
- Fix threads ordering for useUserThreads
@GuillaumeSalles
Add missing JSDoc
e294edb
Bump to 2.4.1-test4
62c090c
@marcbouchenoire
Tweak JSDoc
18c9cf9
@marcbouchenoire
Call resolveMentionSuggestions earlier
26778a6
@marcbouchenoire
Deduplicate mention suggestions calls
830fc3c
@marcbouchenoire
Tweak CHANGELOG.md
69349a2
Base automatically changed from various-comments-fixes to release-2.5.0 August 12, 2024 12:17
An error occurred while trying to automatically change base from various-comments-fixes to release-2.5.0 August 12, 2024 12:17
Base automatically changed from release-2.5.0 to main August 12, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvie nvie Awaiting requested review from nvie nvie will be requested when the pull request is marked ready for review nvie is a code owner

@SugarDarius SugarDarius Awaiting requested review from SugarDarius SugarDarius will be requested when the pull request is marked ready for review SugarDarius is a code owner

@jrowny jrowny Awaiting requested review from jrowny jrowny will be requested when the pull request is marked ready for review jrowny is a code owner

@nimeshnayaju nimeshnayaju Awaiting requested review from nimeshnayaju nimeshnayaju will be requested when the pull request is marked ready for review nimeshnayaju is a code owner

@ofoucherot ofoucherot Awaiting requested review from ofoucherot ofoucherot will be requested when the pull request is marked ready for review ofoucherot is a code owner

@FlowFlorent FlowFlorent Awaiting requested review from FlowFlorent FlowFlorent will be requested when the pull request is marked ready for review FlowFlorent is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcbouchenoire @GuillaumeSalles