Prototype comments without websocket & with toggle on polling #1863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlowFlorent
commented
Jul 30, 2024
FlowFlorent
force-pushed
the
prototype-comments-no-ws
branch
from
0e2a807 to
5db2c44
Compare
FlowFlorent
commented
Jul 30, 2024
| <Thread key={thread.id} thread={thread} className="thread" /> | ||
| ))} | ||
| <Composer className="composer" /> | ||
| <Composer className="composer" disabled={false}/> |
Contributor
Author
There was a problem hiding this comment.
does not work, explore why
FlowFlorent
commented
Jul 30, 2024
| } | ||
|
|
||
|
|
||
| export function useIsVisible(ref: React.RefObject<Element>): boolean { |
Contributor
Author
There was a problem hiding this comment.
does not work yet
FlowFlorent
commented
Jul 30, 2024
| <ComposerInsertMentionEditorAction | ||
| label={$.COMPOSER_INSERT_MENTION} | ||
| disabled={isDisabled} | ||
| disabled={false} |
Contributor
Author
There was a problem hiding this comment.
dirty enable logic, understand why composer doesn't allow focus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This aims to setup a prototype for an application which renders a list of many rooms in a single page (up to 500). Only a few rooms are in view at a time (roughly 25).
Each room must have the comments functionality available. It is acceptable for comments to not be live and be polled at an interval.
To achieve that, two things must be done:
What's needed for
autoConnectto work well:What's needed for
hiddenEnablePolling:hiddenEnablePolling