Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor suggestions #4

Open
derhuerst opened this issue Feb 18, 2022 · 1 comment
Open

minor suggestions #4

derhuerst opened this issue Feb 18, 2022 · 1 comment
Assignees
@konhi

Comments

@derhuerst
Copy link

derhuerst commented Feb 18, 2022 •
edited
Loading

Thanks for this great API! With a few minor exceptions, it ran out-of-the-box!

I ran this API locally, but because the OpenAPI spec hard-codes the poland-public-transport-api.azurewebsites.net publicly deployed instance, and because that instance is currently down, the local OpenAPI playground doesn't work.

https://github.com/konhi/poland-public-transport-api/blob/main/src/public/v1/openapi.json#L19

Currently, there are two logging formats mixed: JSON-based general logs about the server starting etc., and CLF for the actual requests.

What do you think about unifying them into one format, so that people running instances can process all logs with one set of tooling?
@konhi
Copy link
Owner

konhi commented Feb 18, 2022

Thank you for letting me know! I definitely will work on:

  • OpenAPI domain being hard-coded
  • unified logging, which I agree is important for such thing!

These are extremely useful tips for a beginner like me, thanks!

@konhi konhi self-assigned this Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konhi konhi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@derhuerst @konhi