Add JSON marshaling for non-CRD types #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have this for CRD types, where it is strictly required to work with k8s, but not for our other types. This makes it problematic to marshal json for these types. Note you can directly use protobuf json library, but this doesn't work for nested types, hence the desire to have these. Low cost, some value.
howardjohn
added
the
release-notes-none
istio-testing
added
the
size/XS
zirain
approved these changes
Oct 30, 2024
hzxuzhonghu
approved these changes
Oct 31, 2024
istio-policy-bot
added
the
lifecycle/stale
istio-policy-bot
added
the
lifecycle/automatically-closed
istio-policy-bot
removed
the
lifecycle/stale
howardjohn
removed
the
lifecycle/automatically-closed
keithmattix
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have this for CRD types, where it is strictly required to work with
k8s, but not for our other types. This makes it problematic to marshal
json for these types.
Note you can directly use protobuf json library, but this doesn't work
for nested types, hence the desire to have these. Low cost, some value.