New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix harelba/q#62 #88

Open

askelias wants to merge 1 commit into harelba:master from askelias:master

askelias commented Dec 22, 2014

Hello, thanks for your time and efforts maintaining q

I was hurted by #62 so here is my patch

Sorry, it breaks test_one_row_of_data_with_header_param

Also does not produce 'Warning - data is empty', but it is intentional:

there is no way to hide warnings without filtering real errors (all in stderr)
empty data is nominal case to me, especially for LEFT JOIN

So let's discuss what can be done

Thanks


          fix harelba#62

494b180

Owner

harelba commented Dec 23, 2014

Hi, sorry for the late reply. Too much stuff in my day job the last days...

I'd be glad to take a deeper look on your changes later on this week.

Thanks for the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet