-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing detection_snr argument #1615
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1615 +/- ##
======================================
Coverage 94.2% 94.3%
======================================
Files 238 239 +1
Lines 18282 18391 +109
======================================
+ Hits 17232 17343 +111
+ Misses 1050 1048 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Duncan Macleod <[email protected]>
@duncanmmacleod I just updated this PR - it should be ready for you to look over again |
@dethodav, sorry for the delay, can you update the package metadata to include the new minimum version requirement? |
This PR addresses #1614 to correctly pass the
detection_snr
argument toinspiral_range.range()
.With this update, the
inspired_range()
function returns sensible values:Closes #1614