Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capability for Dual Y Axis #719

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Capability for Dual Y Axis #719

wants to merge 2 commits into from

Conversation

wballard
Copy link

Using a bitmask approach, along with a small change to the Makefile to allow different platforms and CPUs with variables rather than needing to fork/edit.

change to the Makefile to allow different platforms and CPUs with
variables rather than needing to fork/edit.
@chamnit
Copy link
Member

chamnit commented May 30, 2015

It's really hard to tell what you changed and if anything else got altered because the commit includes removing hundreds of random space characters.

@wballard
Copy link
Author

wballard commented Jun 2, 2015

Ahh, I see that. Is your editor not set to strip trailing space?

Options -- certainly not the only three

  • I'll see what git can do to generate a patch that excludes those 'non edits'
  • If you can set your editor to strip trailing white, save/commit all I can rebase.
  • Or I can to the same, two PRs, one pure whitespace scrub, another the actual patch.

Sad thing is I'm going back down to one Y, just figured others may benefit doing this in software instead of fussing with dual wiring!

@wballard
Copy link
Author

wballard commented Jun 2, 2015

Oh -- or, I just learned a new github trick:

https://github.com/grbl/grbl/pull/719/files?w=0

?w=0 you can tack on to any diff. cool.

@chamnit
Copy link
Member

chamnit commented Jun 3, 2015

@wballard : Thanks for fixing that. I'll review when I get caught up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants