Fix GTK runtime errors generated by the plugin manager #4079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of geany_wrap_label_new() together with the list below seems to interact in a strange way somehow and generate lots of runtime warnings/errors. This is a (cowardly) attempt by fixing this without having to understand what is going on ;-). Simply using gtk_label_new() seems to resolve the issue. Also, I think the text can be made a bit shorter in case the translation is too wide for some languages. The "at startup" is kind of misleading anyway since plugins are loaded immediately when checked in the box below and since this is a preference, it's remembered so I think it's pretty clear it happens at startup too. Fixes geany#2065.
eht16
approved these changes
Dec 1, 2024
|
Unless there are any objections, I'd merge this in about a week. @b4n I noticed you assigned yourself to this PR. Knowing you, I assume you want to dive into the depths of GTK and fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
geany_wrap_label_new()together with the list below seems to interact in a strange way somehow and generate lots of runtime warnings/errors.This is a (cowardly) attempt by fixing this without having to understand what is going on ;-). Simply using
gtk_label_new()seems to resolve the issue.Also, I think the text can be made a bit shorter in case the translation is too wide for some languages. The "at startup" is kind of misleading anyway since plugins are loaded immediately when checked in the box below and since this is a preference, it's remembered so I think it's pretty clear it happens at startup too.
Just a historical note - the text used to be much longer in the past so this is probably why geany_wrap_label_new() was
used: b0cd7b9
Fixes #2065.