Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Evals] Update dataset schema types to match ActionSchema #1201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Evals] Update dataset schema types to match ActionSchema #1201

wants to merge 1 commit into from

Conversation

shrutip90
Copy link
Contributor

@shrutip90 shrutip90 commented Nov 7, 2024 •
edited by ssbushi
Loading

Checklist (if applicable):

  • Tested (manually, unit tested, etc.)

ssbushi
ssbushi approved these changes Nov 7, 2024
View reviewed changes
genkit-tools/common/src/types/eval.ts Outdated
.record(z.any())
.describe('Valid JSON Schema for the `reference` field of dataset entry.')
.optional(),
inputSchema: JSONSchema7Schema,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a test that's failing. Please update :)

@ssbushi ssbushi changed the title Update input and reference schema types in DatasetSchema to match tho… [Evals] Update dataset schema types to match ActionSchema Nov 7, 2024
@shrutip90 shrutip90 changed the base branch from next to main November 13, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbushi ssbushi ssbushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Genkit Backlog
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrutip90 @ssbushi