Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ingress settings support in firebase functions #2924

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Add ingress settings support in firebase functions #2924

merged 4 commits into from
Jan 12, 2021

Conversation

takaaa220
Copy link
Contributor

Description

Supports firebase-functions SDK in firebase/firebase-functions#815 and firebase/firebase-functions#827

functions
  .runWith({
    ingressSettings: "ONLY_INTERNAL_ONLY",
  })
  .https.onRequest(() => {
  ...
  });

Scenarios Tested

I've created a new cloud function with specific ingressSettings and it works! and, I updated its function and it also works!

Sample Commands

No change in cli.

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Dec 12, 2020
@takaaa220 takaaa220 mentioned this pull request Dec 12, 2020
Merged
@samtstern
Copy link
Contributor

@takaaa220 thanks for this contribution! Hopefully @joehan can take a look at firebase/firebase-functions#827 first and then review this one.

@takaaa220
Copy link
Contributor Author

takaaa220 commented Dec 24, 2020 •
edited
Loading

@joehan
Thank your for reviewing. I will resolve conflicts this week 🙇

@coveralls
Copy link

coveralls commented Jan 12, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 65.558% when pulling 93f986b on takaaa220:add-ingress-settings-support-in-firebase-functions into 67cff84 on firebase:master.

@joehan joehan merged commit fca0381 into firebase:master Jan 12, 2021
joehan added a commit that referenced this pull request Jan 12, 2021
@joehan
restoring changelog and adding entry for #2924
27c3078
@joehan joehan mentioned this pull request Jan 12, 2021
Merged
joehan added a commit that referenced this pull request Jan 12, 2021
@joehan @bkendall
Restore changelog and add entry for #2924 (#3023)
1159782 
* restoring changelog and adding entry for #2924

* Update CHANGELOG.md

Co-authored-by: Bryan Kendall <[email protected]>
This was referenced Mar 9, 2021
Closed
Closed
Closed
@joehan joehan mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehan joehan joehan approved these changes

Assignees

@joehan joehan

Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@takaaa220 @samtstern @coveralls @joehan