Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow http when using emulator #8392

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Allow http when using emulator #8392

merged 2 commits into from
Jul 15, 2021

Conversation

morganchen12
Copy link
Contributor

Fixes #8389.

@morganchen12 morganchen12 added this to the 8.5.0 - M101 milestone Jul 15, 2021
@google-cla google-cla bot added the cla: yes label Jul 15, 2021
@google-oss-bot
Copy link

google-oss-bot commented Jul 15, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseStorage-iOS-FirebaseStorage.framework

    SDK overall coverage changed from 60.40% (5268705) to 60.44% (62c6cdc) by +0.03%.

    Filename Base (5268705) Head (62c6cdc) Diff
    FIRStorage.m 79.11% 79.32% +0.21%

Test Logs

@morganchen12 morganchen12 merged commit a020787 into master Jul 15, 2021
@morganchen12 morganchen12 deleted the mc/storage branch July 15, 2021 21:03
@morganchen12 morganchen12 mentioned this pull request Jul 15, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees
No one assigned
Labels
api: storage cla: yes
Projects
None yet
Milestone
8.5.0 - M101
Development

Successfully merging this pull request may close these issues.

Firebase Storage emulator, crash when uploading from LAN
3 participants
@morganchen12 @google-oss-bot @schmidt-sebastian