Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop calling deprecated sendLogsWithServiceName #3333

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Stop calling deprecated sendLogsWithServiceName #3333

merged 1 commit into from
Jul 11, 2019

Conversation

paulb777
Copy link
Member

This is the open source part of b/137222285.

The implementation in FirebaseCore can be removed after the closed source part is done.

@paulb777
Copy link
Member Author

paulb777 commented Jul 11, 2019 •
edited
Loading

cc: @chliangGoogle @dmandar

@paulb777
Copy link
Member Author

cc: @mikehaney24

@paulb777 paulb777 merged commit b35ca19 into master Jul 11, 2019
@paulb777 paulb777 deleted the pb-stop-sendLogsWithServiceName branch July 11, 2019 14:05
@firebase firebase locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @maksymmalyhin @googlebot