Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useMessagingDelegateForDirectChannel property #2711

Merged
merged 12 commits into from
Apr 4, 2019
Merged

Remove useMessagingDelegateForDirectChannel property #2711

merged 12 commits into from
Apr 4, 2019

Conversation

charlotteliang
Copy link
Contributor

[FCM I/O breaking change] Remove useMessagingDelegateForDirectChannel property

All direct channels (non-apns) messages will be handled by messaging:didReceiveMessage:. Previously iOS 9 and below is handled in application:didReceiveRemoteNotification:fetchCompletionHandler: and this behavior can be changed by setting useMessagingDelegateForDirectChannel to true. Now that all messages by default are handled in messaging:didReceiveMessage:. This boolean value is no longer needed.

If you already have useMessagingDelegateForDirectChannel= YES, or handle all your direct channel messages in messaging:didReceiveMessage:. This change should not affect you.

@charlotteliang charlotteliang added this to the Firebase 6 milestone Apr 2, 2019
ryanwilson
ryanwilson reviewed Apr 3, 2019
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits but mostly LGTM!

Firebase/Messaging/FIRMessagingReceiver.m Outdated Show resolved Hide resolved
Firebase/Messaging/FIRMessagingReceiver.m Outdated Show resolved Hide resolved
Firebase/Messaging/FIRMessagingReceiver.m Show resolved Hide resolved
Firebase/Messaging/FIRMessagingReceiver.m Outdated Show resolved Hide resolved
ryanwilson and others added 4 commits April 2, 2019 22:33
@ryanwilson
Add quick instructions for building the Zip. (#2545)
aedc47c 
* Add quick instructions for building the Zip.

Added some instructions to build the zip. Will expand further with releasing information.

* Further argument instructions, formatting.

* Split out required arguments from optional arguments.

* Remove trailing whitespace.
@maksymmalyhin
GULAppDelegateSwizzler - remote notifications methods and tvOS support (
8cc5d65 
#2698)
@charlotteliang
remove more logic that is no longer needed
f7ace7f
@charlotteliang
remove the unnecessary init method
d5ef7a2
ryanwilson
ryanwilson approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ryanwilson
ryanwilson reviewed Apr 3, 2019
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - please fix the Travis tests before submitting.

@charlotteliang
Copy link
Contributor Author

Not sure the travis failure in Function is related to us:

Creating functions in /var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/firebase-functions.nPsYJTDH
npm ERR! code CERT_NOT_YET_VALID
npm ERR! errno CERT_NOT_YET_VALID
npm ERR! request to https://registry.npmjs.org/firebase-admin failed, reason: certificate is not yet valid

paulb777
paulb777 reviewed Apr 3, 2019
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like GoogleUtilities changes got mixed into this PR?

@charlotteliang
Copy link
Contributor Author

charlotteliang commented Apr 3, 2019 •
edited
Loading

Good catch! Remove those out of this PR.

@charlotteliang charlotteliang merged commit ec23996 into master Apr 4, 2019
@charlotteliang charlotteliang deleted the fcm-message-delegate branch April 4, 2019 22:24
Corrob pushed a commit that referenced this pull request Apr 25, 2019
@charlotteliang @Corrob
Remove useMessagingDelegateForDirectChannel property (#2711)
3a93066
@vol24pl
Copy link

vol24pl commented Aug 1, 2019

Please update the documentation: https://firebase.google.com/docs/cloud-messaging/ios/receive

Also, set the useMessagingDelegateForDirectChannel flag to YES in the AppDelegate and implement messaging:didReceiveMessage:. Your app can still receive APNs messages with or without this callback, but for direct messages from FCM you'll need it.

@morganchen12
Copy link
Contributor

Thanks @vol24pl, we'll update the docs.

Googlers: See cr/261154357

@firebase firebase locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

@paulb777 paulb777 paulb777 left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@charlotteliang @vol24pl @morganchen12 @paulb777 @ryanwilson @googlebot @maksymmalyhin