Fix Auth Domain search code to match comment #13042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
approved these changes
May 31, 2024
Member
ncooke3
left a comment
ncooke3
left a comment
There was a problem hiding this comment.
LGTM! optional: Should a unit test be added to assert this behavior? And a changelog entry?
Member
Author
|
@ncooke3 Thanks for keeping me honest. I've updated the unit tests so it fails with the old code and passes with the new - and added a CHANGELOG update. |
ncooke3
approved these changes
May 31, 2024
Member
ncooke3
left a comment
ncooke3
left a comment
There was a problem hiding this comment.
LGTM! CI failure looks GoogleUtilities related and can be ignored
Member
Author
|
Merging here. I'll address any additional comments in a later PR. |
pragatimodi
pushed a commit
that referenced
this pull request
Jun 10, 2024
pragatimodi
pushed a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7992