-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect comment in code. #7992
Comments
I found a few problems with this issue:
|
Just to make my initial comment a bit clearer: Currently, the If If the response order was different: And thus, contrary to the comment, it's not the order of |
@rosalyntan Should the comment be fixed or the code updated to match the comment? cc: @renkelvin |
I think we should update the code to match the comment. |
The code is updated in the release-11.0 branch: https://github.com/firebase/firebase-ios-sdk/blob/release-11.0/FirebaseAuth/Sources/Swift/Utilities/AuthWebUtils.swift#L117 |
Well, on line 130 and 131 the iteration of supportedAuthDomains is still nested in the iteration of the response domains, so the order or supportedAuthDomains still doesn't matter, does it? |
Oops. Good catch, Morten! I'll reopen the issue and send a PR. |
The comment on the referred line specifies that the order of
supportedAuthDomains
matters. But the outer loop is the authorized domains from the web request, so actually the first match in the authorized domains list 'wins'.The inner and outer loops should be switched for the comment to be correct.
firebase-ios-sdk/FirebaseAuth/Sources/Utilities/FIRAuthWebUtils.m
Line 107 in 31307cd
The text was updated successfully, but these errors were encountered: