Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve github action naming #6529

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Improve github action naming #6529

merged 1 commit into from
Nov 22, 2024

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Nov 21, 2024

Make them more descriptive

Make them more descriptive
Copy link
Contributor

github-actions bot commented Nov 21, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

Copy link
Contributor

Test Results

 1 036 files  ±0   1 036 suites  ±0   36m 59s ⏱️ +22s
 5 873 tests ±0   5 851 ✅ ±0  22 💤 ±0  0 ❌ ±0 
11 831 runs  ±0  11 787 ✅ ±0  44 💤 ±0  0 ❌ ±0 

Results for commit 939626c. ± Comparison against base commit 6a03d4c.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.71% (6a03d4c) to 45.73% (e12b871) by +0.01%.

    FilenameBase (6a03d4c)Merge (e12b871)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    LruGarbageCollector.java93.64%97.27%+3.64%
    PatchMutation.java98.39%100.00%+1.61%
  • firebase-messaging

    Overall coverage changed from 84.15% (6a03d4c) to 84.12% (e12b871) by -0.04%.

    FilenameBase (6a03d4c)Merge (e12b871)Diff
    FirebaseMessaging.java76.00%76.40%+0.40%
    RequestDeduplicator.java90.00%80.00%-10.00%
  • firebase-storage

    Overall coverage changed from ? (6a03d4c) to 83.96% (e12b871) by ?.

    48 individual files with coverage change

    FilenameBase (6a03d4c)Merge (e12b871)Diff
    ActivityLifecycleListener.java?74.14%?
    AdaptiveStreamBuffer.java?84.62%?
    CancelException.java?100.00%?
    CancellableTask.java?100.00%?
    ControllableTask.java?100.00%?
    DeleteNetworkRequest.java?100.00%?
    DeleteStorageTask.java?100.00%?
    ExponentialBackoffSender.java?86.00%?
    FileDownloadTask.java?80.00%?
    FirebaseStorage.java?83.67%?
    FirebaseStorageComponent.java?100.00%?
    GetDownloadUrlTask.java?96.77%?
    GetMetadataNetworkRequest.java?100.00%?
    GetMetadataTask.java?85.19%?
    GetNetworkRequest.java?100.00%?
    HttpURLConnectionFactory.java?0.00%?
    HttpURLConnectionFactoryImpl.java?50.00%?
    ListNetworkRequest.java?100.00%?
    ListResult.java?100.00%?
    ListTask.java?85.71%?
    NetworkRequest.java?87.29%?
    OnPausedListener.java?0.00%?
    OnProgressListener.java?0.00%?
    ResumableNetworkRequest.java?100.00%?
    ResumableUploadByteRequest.java?90.91%?
    ResumableUploadCancelRequest.java?100.00%?
    ResumableUploadQueryRequest.java?100.00%?
    ResumableUploadStartRequest.java?95.24%?
    Slashes.java?88.24%?
    Sleeper.java?0.00%?
    SleeperImpl.java?100.00%?
    SmartHandler.java?92.31%?
    Storage.kt?39.58%?
    StorageException.java?65.45%?
    StorageMetadata.java?86.34%?
    StorageReference.java?89.94%?
    StorageReferenceUri.java?100.00%?
    StorageRegistrar.java?100.00%?
    StorageTask.java?83.38%?
    StorageTaskManager.java?100.00%?
    StorageTaskScheduler.java?95.45%?
    StreamDownloadTask.java?88.89%?
    TaskListenerImpl.java?100.00%?
    TaskState.kt?0.00%?
    UpdateMetadataNetworkRequest.java?100.00%?
    UpdateMetadataTask.java?82.14%?
    UploadTask.java?81.52%?
    Util.java?73.24%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UBdi2Ur3jp.html

@rlazo rlazo merged commit f1c75df into main Nov 22, 2024
264 of 266 checks passed
@rlazo rlazo deleted the rl.action.naming branch November 22, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants