Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migrate FirebaseLibraryExtension to Kotlin #6092

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Jul 10, 2024

WIP PR to see CI results

Copy link
Contributor

github-actions bot commented Jul 10, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

1 similar comment
Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 10, 2024

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.22% (ecea64b) to 50.17% (2be606a) by -0.05%.

    FilenameBase (ecea64b)Merge (2be606a)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
    QueryParams.java90.36%89.76%-0.60%
  • firebase-firestore

    Overall coverage changed from 45.89% (ecea64b) to 45.89% (2be606a) by +0.00%.

    FilenameBase (ecea64b)Merge (2be606a)Diff
    SetMutation.java94.44%97.22%+2.78%
  • firebase-messaging

    Overall coverage changed from 84.26% (ecea64b) to 84.18% (2be606a) by -0.07%.

    FilenameBase (ecea64b)Merge (2be606a)Diff
    RequestDeduplicator.java90.00%80.00%-10.00%
  • ktx

    Overall coverage changed from ? (ecea64b) to 100.00% (2be606a) by ?.

    FilenameBase (ecea64b)Merge (2be606a)Diff
    Logging.kt?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Yz4tzqrM0J.html

Copy link
Contributor

Unit Test Results

0 files   -      950  0 suites   - 950   0s ⏱️ - 34m 57s
0 tests  -   5 211  0 ✔️  -   5 190  0 💤  - 21  0 ±0 
0 runs   - 10 507  0 ✔️  - 10 465  0 💤  - 42  0 ±0 

Results for commit 6e298a3. ± Comparison against base commit ecea64b.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-components

    TypeBase (ecea64b)Merge (2be606a)Diff
    aar45.7 kB4.17 kB-41.6 kB (-90.9%)
  • firebase-config

    TypeBase (ecea64b)Merge (2be606a)Diff
    aar108 kB3.26 kB-105 kB (-97.0%)
  • firebase-installations

    TypeBase (ecea64b)Merge (2be606a)Diff
    aar57.7 kB3.20 kB-54.5 kB (-94.5%)
  • firebase-messaging

    TypeBase (ecea64b)Merge (2be606a)Diff
    aar148 kB3.54 kB-145 kB (-97.6%)
  • ktx

    TypeBase (ecea64b)Merge (2be606a)Diff
    aar?3.52 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Mo1e3KeQdK.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,608 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/arJ4POm5MZ/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants