Tomandersen/handshake rewrite #6015
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per [b/338407806](https://b.corp.google.com/issues/338407806), This fixes the issues with the health metrics action failing. It seemed to stem from a bunch of outdated dependencies in the health metrics sub projects.
… tomandersen/watchHandshake # Conflicts: # firebase-firestore/src/main/java/com/google/firebase/firestore/remote/RemoteStore.java
…andersen/watchHandshake # Conflicts: # firebase-firestore/src/main/java/com/google/firebase/firestore/remote/RemoteStore.java
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/FirebaseFirestore.html 2024-08-16 16:20:42.695732541 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/FirebaseFirestore.html 2024-08-16 16:18:10.756215494 +0000
@@ -1193,7 +1193,7 @@
<p>After calling <code>terminate()</code> only the <code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html#clearPersistence()">clearPersistence</a></code> method may be used. Any other method will throw an <code><a href="https://developer.android.com/reference/kotlin/java/lang/IllegalStateException.html">IllegalStateException</a></code>. </p>
<p>To restart after termination, simply create a new instance of <code>FirebaseFirestore</code> with <code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html#getInstance()">getInstance</a></code> or <code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html#getInstance(com.google.firebase.FirebaseApp)">getInstance</a></code>. </p>
<p><code>terminate()</code> does not cancel any pending writes but any write tasks that are awaiting a response from the server will not be resolved. The next time you start this instance, it will resume attempting to send these writes to the server. </p>
- <p>Note: Under normal circumstances, calling <code>terminate()</code> is not required. This method is useful only when you want to force this instance to release all of its resources or in combination with clearPersistence to ensure that all local state is destroyed between test runs.</p>
+ <p>Note: Under normal circumstances, calling <code>terminate()</code> is not required. This method is useful only when you want to force this instance to release all of its resources or in combination with <code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html#clearPersistence()">clearPersistence</a></code> to ensure that all local state is destroyed between test runs.</p>
<div class="devsite-table-wrapper">
<table class="responsive">
<colgroup>--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/FirebaseFirestore.html 2024-08-16 16:20:42.635732732 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/FirebaseFirestore.html 2024-08-16 16:18:10.732215571 +0000
@@ -1152,7 +1152,7 @@
<p>After calling <code>terminate()</code> only the <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html#clearPersistence()">clearPersistence</a></code> method may be used. Any other method will throw an <code><a href="https://developer.android.com/reference/kotlin/java/lang/IllegalStateException.html">IllegalStateException</a></code>. </p>
<p>To restart after termination, simply create a new instance of <code>FirebaseFirestore</code> with <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html#getInstance()">getInstance</a></code> or <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html#getInstance(com.google.firebase.FirebaseApp)">getInstance</a></code>. </p>
<p><code>terminate()</code> does not cancel any pending writes but any write tasks that are awaiting a response from the server will not be resolved. The next time you start this instance, it will resume attempting to send these writes to the server. </p>
- <p>Note: Under normal circumstances, calling <code>terminate()</code> is not required. This method is useful only when you want to force this instance to release all of its resources or in combination with clearPersistence to ensure that all local state is destroyed between test runs.</p>
+ <p>Note: Under normal circumstances, calling <code>terminate()</code> is not required. This method is useful only when you want to force this instance to release all of its resources or in combination with <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html#clearPersistence()">clearPersistence</a></code> to ensure that all local state is destroyed between test runs.</p>
<div class="devsite-table-wrapper">
<table class="responsive">
<colgroup> |
Size Report 1Affected Products
Test Logs |
tom-andersen
changed the base branch from
tomandersen/streamRefactor
to
tomandersen/componentProviderRefactor
…actor' into tomandersen/handshakeRewrite # Conflicts: # firebase-firestore/src/androidTest/java/com/google/firebase/firestore/AccessHelper.java # firebase-firestore/src/androidTest/java/com/google/firebase/firestore/remote/RemoteStoreTest.java # firebase-firestore/src/androidTest/java/com/google/firebase/firestore/testutil/IntegrationTestUtil.java # firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestore.java # firebase-firestore/src/main/java/com/google/firebase/firestore/core/FirestoreClient.java # firebase-firestore/src/main/java/com/google/firebase/firestore/core/MemoryComponentProvider.java # firebase-firestore/src/main/java/com/google/firebase/firestore/remote/FirestoreChannel.java # firebase-firestore/src/main/java/com/google/firebase/firestore/remote/RemoteComponenetProvider.java # firebase-firestore/src/main/java/com/google/firebase/firestore/remote/RemoteStore.java # firebase-firestore/src/main/java/com/google/firebase/firestore/remote/WriteStream.java # firebase-firestore/src/test/java/com/google/firebase/firestore/spec/MemorySpecTest.java # firebase-firestore/src/test/java/com/google/firebase/firestore/spec/SQLiteSpecTest.java # firebase-firestore/src/test/java/com/google/firebase/firestore/spec/SpecTestCase.java
…/handshakeRewrite
…tomandersen/handshakeRewrite # Conflicts: # firebase-firestore/src/test/java/com/google/firebase/firestore/integration/AsyncTaskAccumulator.java # firebase-firestore/src/test/java/com/google/firebase/firestore/integration/FirebaseFirestoreTest.java
tom-andersen
changed the base branch from
tomandersen/componentProviderRefactor
to
tomandersen/handshakeTest
…der' into tomandersen/handshakeRewrite # Conflicts: # firebase-firestore/src/androidTest/java/com/google/firebase/firestore/ValidationTest.java # firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestore.java # firebase-firestore/src/main/java/com/google/firebase/firestore/FirestoreClientProvider.java # firebase-firestore/src/main/java/com/google/firebase/firestore/core/FirestoreClient.java # firebase-firestore/src/test/java/com/google/firebase/firestore/FirebaseFirestoreIntegrationTestFactory.java
tom-andersen
changed the base branch from
tomandersen/handshakeTest
to
tomandersen/firestoreClientProvider
…der' into tomandersen/handshakeRewrite # Conflicts: # firebase-firestore/src/androidTest/java/com/google/firebase/firestore/AccessHelper.java # firebase-firestore/src/androidTest/java/com/google/firebase/firestore/CompositeIndexQueryTest.java # firebase-firestore/src/androidTest/java/com/google/firebase/firestore/testutil/IntegrationTestUtil.java # firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestore.java # firebase-firestore/src/main/java/com/google/firebase/firestore/FirestoreClientProvider.java # firebase-firestore/src/main/java/com/google/firebase/firestore/core/FirestoreClient.java # firebase-firestore/src/test/java/com/google/firebase/firestore/FirebaseFirestoreIntegrationTestFactory.java # firebase-firestore/src/test/java/com/google/firebase/firestore/integration/FirebaseFirestoreTest.java
…rsOnTerminate' into tomandersen/handshakeRewrite # Conflicts: # firebase-firestore/src/main/java/com/google/firebase/firestore/core/FirestoreClient.java
tom-andersen
changed the base branch from
tomandersen/firestoreClientProvider
to
tomandersen/abortSnapshotListenersOnTerminate
…andersen/handshakeRewrite
Vertex AI Mock Responses Check
|
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.