Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add semver test for PRs targeting master #5511

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add semver test for PRs targeting master #5511

wants to merge 6 commits into from

Conversation

emilypgoogle
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 3, 2023 •
edited
Loading

Size Report 1

Affected Products

  • firebase-common

    TypeBase (2865f2b)Merge (7475b7d)Diff
    aar107 kB107 kB-3 B (-0.0%)

  • firebase-config

    TypeBase (2865f2b)Merge (7475b7d)Diff
    aar109 kB109 kB+5 B (+0.0%)

  • firebase-database-collection

    TypeBase (2865f2b)Merge (7475b7d)Diff
    aar33.7 kB33.7 kB+1 B (+0.0%)

  • firebase-inappmessaging

    TypeBase (2865f2b)Merge (7475b7d)Diff
    aar461 kB461 kB-8 B (-0.0%)
    apk (release)11.7 MB11.7 MB+12 B (+0.0%)

  • firebase-inappmessaging-display

    TypeBase (2865f2b)Merge (7475b7d)Diff
    aar184 kB184 kB-8 B (-0.0%)

  • firebase-inappmessaging-display-ktx

    TypeBase (2865f2b)Merge (7475b7d)Diff
    aar17.4 kB17.4 kB+2 B (+0.0%)

  • firebase-inappmessaging-ktx

    TypeBase (2865f2b)Merge (7475b7d)Diff
    aar4.82 kB4.81 kB-4 B (-0.1%)
    apk (release)11.7 MB11.7 MB+12 B (+0.0%)

  • firebase-perf

    TypeBase (2865f2b)Merge (7475b7d)Diff
    apk (aggressive)1.98 MB1.88 MB-103 kB (-5.2%)
    apk (release)9.25 MB9.15 MB-104 kB (-1.1%)

  • firebase-perf-ktx

    TypeBase (2865f2b)Merge (7475b7d)Diff
    apk (aggressive)1.98 MB1.88 MB-103 kB (-5.2%)
    apk (release)9.27 MB9.17 MB-104 kB (-1.1%)

  • protolite-well-known-types

    TypeBase (2865f2b)Merge (7475b7d)Diff
    aar1.00e+03 kB1.00e+03 kB-2 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6VXKhpxYlO.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 3, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (2865f2b) to 75.99% (7475b7d) by ?.

    68 individual files with coverage change

    FilenameBase (2865f2b)Merge (7475b7d)Diff
    AabUpdater.java?98.36%?
    AabUpdater_Factory.java?0.00%?
    ApkInstaller.java?100.00%?
    ApkInstaller_Factory.java?0.00%?
    ApkUpdater.java?92.63%?
    ApkUpdater_Factory.java?0.00%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppDistroComponent.java?0.00%?
    AppDistroComponent_MainModule_BindContentResolverFactory.java?0.00%?
    AppIconSource.java?84.62%?
    AppIconSource_Factory.java?100.00%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?71.58%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    DaggerAppDistroComponent.java?80.56%?
    DevModeDetector.java?9.09%?
    DevModeDetector_Factory.java?100.00%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?3.39%?
    FeedbackActivity_MembersInjector.java?0.00%?
    FeedbackSender.java?84.48%?
    FeedbackSender_Factory.java?0.00%?
    FeedbackTrigger.java?61.54%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?89.89%?
    FirebaseAppDistributionImpl_Factory.java?0.00%?
    FirebaseAppDistributionLifecycleNotifier.java?91.49%?
    FirebaseAppDistributionLifecycleNotifier_Factory.java?0.00%?
    FirebaseAppDistributionNotificationsManager.java?88.89%?
    FirebaseAppDistributionNotificationsManager_Factory.java?0.00%?
    FirebaseAppDistributionRegistrar.java?95.83%?
    FirebaseAppDistributionTesterApiClient.java?88.78%?
    FirebaseAppDistributionTesterApiClient_Factory.java?0.00%?
    HttpsUrlConnectionFactory.java?50.00%?
    HttpsUrlConnectionFactory_Factory.java?100.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.67%?
    LogWrapper.java?86.67%?
    NewReleaseFetcher.java?86.67%?
    NewReleaseFetcher_Factory.java?0.00%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?91.78%?
    ReleaseIdentifier_Factory.java?0.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?36.17%?
    ScreenshotTaker_Factory.java?0.00%?
    SequentialReference.java?100.00%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?100.00%?
    SignInStorage_Factory.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity_MembersInjector.java?0.00%?
    TaskCache.java?100.00%?
    TaskCompletionSourceCache.java?72.41%?
    TaskUtils.java?77.50%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?90.09%?
    TesterApiHttpClient_Factory.java?0.00%?
    TesterSignInManager.java?95.45%?
    TesterSignInManager_Factory.java?0.00%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskCache.java?91.30%?
    UpdateTaskImpl.java?76.32%?

  • firebase-firestore

    Overall coverage changed from 44.86% (2865f2b) to 44.85% (7475b7d) by -0.00%.

    FilenameBase (2865f2b)Merge (7475b7d)Diff
    DeleteMutation.java95.24%90.48%-4.76%

  • firebase-messaging

    Overall coverage changed from 83.97% (2865f2b) to 84.00% (7475b7d) by +0.04%.

    FilenameBase (2865f2b)Merge (7475b7d)Diff
    FirebaseMessaging.java73.13%72.69%-0.44%
    MessagingAnalytics.java82.00%81.60%-0.40%
    Metadata.java36.51%41.27%+4.76%

  • firebase-ml-modeldownloader

    Overall coverage changed from 83.38% (2865f2b) to 83.32% (7475b7d) by -0.06%.

    FilenameBase (2865f2b)Merge (7475b7d)Diff
    FirebaseModelDownloader.java84.66%84.05%-0.61%

  • firebase-storage

    Overall coverage changed from 83.92% (2865f2b) to 83.96% (7475b7d) by +0.04%.

    FilenameBase (2865f2b)Merge (7475b7d)Diff
    StreamDownloadTask.java88.41%88.89%+0.48%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Wqq1GfPXIC.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 3, 2023 •
edited
Loading

Startup Time Report 1

The report is too large (122,677 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/f7MsEtxgdG/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023 •
edited
Loading

Unit Test Results

     948 files  +  53       948 suites  +53   32m 26s ⏱️ + 1m 6s
  5 186 tests ±    0    5 165 ✔️ +    1  21 💤 ±0  0 ❌  - 1 
10 457 runs  +984  10 415 ✔️ +985  42 💤 ±0  0 ❌  - 1 

Results for commit fc12580. ± Comparison against base commit 2865f2b.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no-changelog size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilypgoogle @google-oss-bot