Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the data collection state is reliable for App Quality Sessions library #5202

Merged
merged 7 commits into from
Aug 15, 2023

Conversation

visumickey
Copy link
Contributor

No description provided.

@visumickey visumickey requested a review from mrober July 26, 2023 19:34
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-perf
### {{perfmon}} version 20.4.1 {: #performance_v20-4-1}

* {{fixed}} Make fireperf data collection state is reliable for Firebase Sessions library.

#### {{perfmon}} Kotlin extensions version 20.4.1 {: #performance-ktx_v20-4-1}

The Kotlin extensions library transitively includes the updated
`firebase-performance` library. The Kotlin extensions library has no additional
updates.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 26, 2023

Coverage Report 1

Affected Products

  • firebase-perf

    Overall coverage changed from ? (da631d2) to 71.21% (26e2d9a) by ?.

    103 individual files with coverage change

    FilenameBase (da631d2)Merge (26e2d9a)Diff
    AddTrace.java?0.00%?
    AndroidApplicationInfo.java?34.71%?
    AndroidApplicationInfoOrBuilder.java?0.00%?
    AndroidLogger.java?100.00%?
    AndroidMemoryReading.java?38.36%?
    AndroidMemoryReadingOrBuilder.java?0.00%?
    ApplicationInfo.java?45.00%?
    ApplicationInfoOrBuilder.java?0.00%?
    ApplicationProcessState.java?73.91%?
    AppStartTrace.java?77.37%?
    AppStateMonitor.java?84.97%?
    AppStateUpdateHandler.java?89.29%?
    Clock.java?100.00%?
    ConfigResolver.java?93.49%?
    ConfigurationConstants.java?97.93%?
    ConfigurationFlag.java?80.00%?
    ConsoleUrlGenerator.java?37.50%?
    Constants.java?95.65%?
    Counter.java?90.91%?
    CpuGaugeCollector.java?92.77%?
    CpuMetricReading.java?39.33%?
    CpuMetricReadingOrBuilder.java?0.00%?
    DaggerFirebasePerformanceComponent.java?100.00%?
    DeviceCacheManager.java?76.42%?
    FirebasePerfApplicationInfoValidator.java?92.86%?
    FirebasePerfEarly.java?86.36%?
    FirebasePerfGaugeMetricValidator.java?100.00%?
    FirebasePerfHttpClient.java?93.85%?
    FirebasePerfMetricProto.java?0.00%?
    FirebasePerfNetworkValidator.java?86.67%?
    FirebasePerfOkHttpClient.java?44.90%?
    FirebasePerformance.java?79.12%?
    FirebasePerformanceAttributable.java?0.00%?
    FirebasePerformanceComponent.java?0.00%?
    FirebasePerformanceInitializer.java?33.33%?
    FirebasePerformanceModule.java?100.00%?
    FirebasePerformanceModule_ProvidesConfigResolverFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseAppFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesSessionManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java?100.00%?
    FirebasePerformance_Factory.java?100.00%?
    FirebasePerfRegistrar.java?100.00%?
    FirebasePerfTraceValidator.java?85.87%?
    FirebasePerfUrlConnection.java?44.26%?
    FirstDrawDoneListener.java?85.71%?
    FlgTransport.java?83.33%?
    FragmentStateMonitor.java?94.87%?
    FrameMetricsCalculator.java?96.77%?
    FrameMetricsRecorder.java?76.32%?
    GaugeManager.java?98.40%?
    GaugeMetadata.java?26.17%?
    GaugeMetadataManager.java?77.78%?
    GaugeMetadataOrBuilder.java?0.00%?
    GaugeMetric.java?39.47%?
    GaugeMetricOrBuilder.java?0.00%?
    HttpMetric.java?92.65%?
    ImmutableBundle.java?100.00%?
    InstrHttpInputStream.java?92.86%?
    InstrHttpOutputStream.java?98.00%?
    InstrHttpsURLConnection.java?94.32%?
    InstrHttpURLConnection.java?93.42%?
    InstrumentApacheHttpResponseHandler.java?100.00%?
    InstrumentOkHttpEnqueueCallback.java?100.00%?
    InstrURLConnectionBase.java?94.86%?
    LogWrapper.java?23.08%?
    MemoryGaugeCollector.java?91.38%?
    NetworkConnectionInfo.java?0.00%?
    NetworkConnectionInfoOrBuilder.java?0.00%?
    NetworkRequestMetric.java?49.16%?
    NetworkRequestMetricBuilder.java?95.97%?
    NetworkRequestMetricBuilderUtil.java?75.00%?
    NetworkRequestMetricOrBuilder.java?0.00%?
    Optional.java?86.67%?
    PendingPerfEvent.java?100.00%?
    PerfMetric.java?33.67%?
    PerfMetricOrBuilder.java?0.00%?
    PerfMetricValidator.java?93.55%?
    PerfSession.java?93.22%?
    PerfSessionOrBuilder.java?0.00%?
    PreDrawListener.java?94.12%?
    Rate.java?100.00%?
    RateLimiter.java?90.77%?
    RemoteConfigManager.java?91.43%?
    ResourceType.java?0.00%?
    ScreenTraceUtil.java?94.12%?
    SessionAwareObject.java?0.00%?
    SessionManager.java?100.00%?
    SessionVerbosity.java?68.42%?
    StorageUnit.java?57.89%?
    Timer.java?90.63%?
    Trace.java?95.83%?
    TraceMetric.java?43.14%?
    TraceMetricBuilder.java?100.00%?
    TraceMetricOrBuilder.java?0.00%?
    TransportInfo.java?0.00%?
    TransportInfoOrBuilder.java?0.00%?
    TransportManager.java?94.88%?
    URLAllowlist.java?94.44%?
    URLWrapper.java?0.00%?
    Utils.java?78.57%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dACMMb4MNc.html

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

Unit Test Results

   102 files  +   100     102 suites  +100   3m 26s ⏱️ + 3m 7s
   971 tests +   970     971 ✔️ +   970  0 💤 ±0  0 ±0 
1 942 runs  +1 940  1 942 ✔️ +1 940  0 💤 ±0  0 ±0 

Results for commit c2e289a. ± Comparison against base commit da631d2.

This pull request removes 1 and adds 971 tests. Note that renamed tests count towards both.
com.google.firebase.datatransport.TransportRegistrationTest ‑ test_componentIsRegisteredAndAvailable
com.google.firebase.perf.FirebasePerfRegistrarTest ‑ testGetComponents
com.google.firebase.perf.FirebasePerformanceTest ‑ firebasePerformanceInitialization_providesRcProvider_remoteConfigManagerIsSet
com.google.firebase.perf.FirebasePerformanceTest ‑ initFirebasePerformance_injectsMetadataIntoConfigResolver
com.google.firebase.perf.FirebasePerformanceTest ‑ initializeFirebasePerformance_emptyMetadataAndCache_metadataAndContextInjected
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceDisabledThenCleared_respectsGlobalFlag
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceDisabledThenCleared_respectsManifestTrue
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceEnabledThenCleared_respectsGlobalFlag
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceEnabledThenCleared_respectsManifestFalse
com.google.firebase.perf.FirebasePerformanceTest ‑ testAddingMoreThanMaxLocalAttributes
com.google.firebase.perf.FirebasePerformanceTest ‑ testBothManifestsAgree
…

♻️ This comment has been updated with latest results.

@visumickey visumickey requested a review from samedson July 26, 2023 19:56
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 26, 2023

Size Report 1

Affected Products

  • firebase-perf

    TypeBase (da631d2)Merge (26e2d9a)Diff
    aar318 kB318 kB+200 B (+0.1%)
    apk (aggressive)1.24 MB1.24 MB+12 B (+0.0%)
    apk (release)3.74 MB3.74 MB+180 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BB85pwrRV1.html

@visumickey visumickey force-pushed the perfDataCollectionStateForSessions branch from 26330d3 to b04efd0 Compare July 26, 2023 20:08
@visumickey
Copy link
Contributor Author

/retest

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 26, 2023

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-perf

    DeviceStatisticsDistributions
    oriole-32
    Percentileda631d226e2d9aDiffSignificant (?)
    p10252 ±20 μs249 ±20 μs-2.83 μs (-1.1%)NO
    p25265 ±22 μs262 ±22 μs-2.40 μs (-0.9%)NO
    p50285 ±23 μs281 ±21 μs-3.91 μs (-1.4%)NO
    p75320 ±24 μs315 ±17 μs-4.25 μs (-1.3%)NO
    p90376 ±21 μs382 ±21 μs+5.45 μs (+1.4%)NO

    20 test runs in comparison
    CommitTest Runs
    da631d2
    • 2023-08-14_18:22:57.022418_OdUn
    • 2023-08-14_18:22:57.025636_vznp
    • 2023-08-14_18:22:57.025647_rQzR
    • 2023-08-14_18:22:57.025653_ewsj
    • 2023-08-14_18:22:57.025659_hSYq
    • 2023-08-14_18:22:57.025799_OEkg
    • 2023-08-14_18:22:57.025807_kRei
    • 2023-08-14_18:22:57.025812_NwEI
    • 2023-08-14_18:22:57.025817_LGjx
    • 2023-08-14_18:22:57.025822_CBaI
    26e2d9a
    • 2023-08-15_07:57:40.263693_NnBA
    • 2023-08-15_07:57:40.266100_fFnY
    • 2023-08-15_07:57:40.266113_CcYC
    • 2023-08-15_07:57:40.266119_WeQd
    • 2023-08-15_07:57:40.266125_JMZR
    • 2023-08-15_07:57:40.266263_RBcP
    • 2023-08-15_07:57:40.266270_UtfE
    • 2023-08-15_07:57:40.266276_FQdD
    • 2023-08-15_07:57:40.266280_yCUz
    • 2023-08-15_07:57:40.266286_IGRp
    redfin-30
    Percentileda631d226e2d9aDiffSignificant (?)
    p10701 ±71 μs712 ±60 μs+10.8 μs (+1.5%)NO
    p25748 ±65 μs746 ±53 μs-1.82 μs (-0.2%)NO
    p50811 ±61 μs827 ±38 μs+16.7 μs (+2.1%)NO
    p75883 ±74 μs932 ±73 μs+49.0 μs (+5.6%)NO
    p90994 ±104 μs1.07 ±0.1 ms+73.0 μs (+7.3%)NO

    20 test runs in comparison
    CommitTest Runs
    da631d2
    • 2023-08-14_18:22:57.022418_OdUn
    • 2023-08-14_18:22:57.025636_vznp
    • 2023-08-14_18:22:57.025647_rQzR
    • 2023-08-14_18:22:57.025653_ewsj
    • 2023-08-14_18:22:57.025659_hSYq
    • 2023-08-14_18:22:57.025799_OEkg
    • 2023-08-14_18:22:57.025807_kRei
    • 2023-08-14_18:22:57.025812_NwEI
    • 2023-08-14_18:22:57.025817_LGjx
    • 2023-08-14_18:22:57.025822_CBaI
    26e2d9a
    • 2023-08-15_07:57:40.263693_NnBA
    • 2023-08-15_07:57:40.266100_fFnY
    • 2023-08-15_07:57:40.266113_CcYC
    • 2023-08-15_07:57:40.266119_WeQd
    • 2023-08-15_07:57:40.266125_JMZR
    • 2023-08-15_07:57:40.266263_RBcP
    • 2023-08-15_07:57:40.266270_UtfE
    • 2023-08-15_07:57:40.266276_FQdD
    • 2023-08-15_07:57:40.266280_yCUz
    • 2023-08-15_07:57:40.266286_IGRp
  • fire-sessions

    DeviceStatisticsDistributions
    oriole-32
    Percentileda631d226e2d9aDiffSignificant (?)
    p107.41 ±1 ms7.93 ±0.6 ms+519 μs (+7.0%)NO
    p257.84 ±1 ms8.28 ±0.5 ms+442 μs (+5.6%)NO
    p508.31 ±1 ms8.88 ±0.5 ms+566 μs (+6.8%)NO
    p759.05 ±1 ms9.81 ±0.6 ms+762 μs (+8.4%)NO
    p9010.2 ±1 ms11.1 ±0.7 ms+933 μs (+9.1%)NO

    20 test runs in comparison
    CommitTest Runs
    da631d2
    • 2023-08-14_18:22:57.022418_OdUn
    • 2023-08-14_18:22:57.025636_vznp
    • 2023-08-14_18:22:57.025647_rQzR
    • 2023-08-14_18:22:57.025653_ewsj
    • 2023-08-14_18:22:57.025659_hSYq
    • 2023-08-14_18:22:57.025799_OEkg
    • 2023-08-14_18:22:57.025807_kRei
    • 2023-08-14_18:22:57.025812_NwEI
    • 2023-08-14_18:22:57.025817_LGjx
    • 2023-08-14_18:22:57.025822_CBaI
    26e2d9a
    • 2023-08-15_07:57:40.263693_NnBA
    • 2023-08-15_07:57:40.266100_fFnY
    • 2023-08-15_07:57:40.266113_CcYC
    • 2023-08-15_07:57:40.266119_WeQd
    • 2023-08-15_07:57:40.266125_JMZR
    • 2023-08-15_07:57:40.266263_RBcP
    • 2023-08-15_07:57:40.266270_UtfE
    • 2023-08-15_07:57:40.266276_FQdD
    • 2023-08-15_07:57:40.266280_yCUz
    • 2023-08-15_07:57:40.266286_IGRp
    redfin-30
    Percentileda631d226e2d9aDiffSignificant (?)
    p1013.6 ±3 ms13.8 ±3 ms+241 μs (+1.8%)NO
    p2514.9 ±4 ms15.4 ±4 ms+460 μs (+3.1%)NO
    p5017.0 ±5 ms18.3 ±5 ms+1.28 ms (+7.5%)NO
    p7520.9 ±6 ms23.0 ±4 ms+2.02 ms (+9.7%)NO
    p9024.1 ±5 ms26.6 ±6 ms+2.47 ms (+10.3%)NO

    20 test runs in comparison
    CommitTest Runs
    da631d2
    • 2023-08-14_18:22:57.022418_OdUn
    • 2023-08-14_18:22:57.025636_vznp
    • 2023-08-14_18:22:57.025647_rQzR
    • 2023-08-14_18:22:57.025653_ewsj
    • 2023-08-14_18:22:57.025659_hSYq
    • 2023-08-14_18:22:57.025799_OEkg
    • 2023-08-14_18:22:57.025807_kRei
    • 2023-08-14_18:22:57.025812_NwEI
    • 2023-08-14_18:22:57.025817_LGjx
    • 2023-08-14_18:22:57.025822_CBaI
    26e2d9a
    • 2023-08-15_07:57:40.263693_NnBA
    • 2023-08-15_07:57:40.266100_fFnY
    • 2023-08-15_07:57:40.266113_CcYC
    • 2023-08-15_07:57:40.266119_WeQd
    • 2023-08-15_07:57:40.266125_JMZR
    • 2023-08-15_07:57:40.266263_RBcP
    • 2023-08-15_07:57:40.266270_UtfE
    • 2023-08-15_07:57:40.266276_FQdD
    • 2023-08-15_07:57:40.266280_yCUz
    • 2023-08-15_07:57:40.266286_IGRp
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentileda631d226e2d9aDiffSignificant (?)
    p10200 ±4 ms205 ±2 ms+4.50 ms (+2.2%)NO
    p25206 ±4 ms211 ±3 ms+4.91 ms (+2.4%)NO
    p50213 ±5 ms219 ±4 ms+5.64 ms (+2.6%)NO
    p75221 ±5 ms227 ±4 ms+6.61 ms (+3.0%)NO
    p90230 ±6 ms238 ±5 ms+7.97 ms (+3.5%)NO

    20 test runs in comparison
    CommitTest Runs
    da631d2
    • 2023-08-14_18:22:57.022418_OdUn
    • 2023-08-14_18:22:57.025636_vznp
    • 2023-08-14_18:22:57.025647_rQzR
    • 2023-08-14_18:22:57.025653_ewsj
    • 2023-08-14_18:22:57.025659_hSYq
    • 2023-08-14_18:22:57.025799_OEkg
    • 2023-08-14_18:22:57.025807_kRei
    • 2023-08-14_18:22:57.025812_NwEI
    • 2023-08-14_18:22:57.025817_LGjx
    • 2023-08-14_18:22:57.025822_CBaI
    26e2d9a
    • 2023-08-15_07:57:40.263693_NnBA
    • 2023-08-15_07:57:40.266100_fFnY
    • 2023-08-15_07:57:40.266113_CcYC
    • 2023-08-15_07:57:40.266119_WeQd
    • 2023-08-15_07:57:40.266125_JMZR
    • 2023-08-15_07:57:40.266263_RBcP
    • 2023-08-15_07:57:40.266270_UtfE
    • 2023-08-15_07:57:40.266276_FQdD
    • 2023-08-15_07:57:40.266280_yCUz
    • 2023-08-15_07:57:40.266286_IGRp
    redfin-30
    Percentileda631d226e2d9aDiffSignificant (?)
    p10244 ±2 ms269 ±7 ms+25.4 ms (+10.4%)MAYBE
    p25250 ±3 ms276 ±7 ms+25.4 ms (+10.2%)MAYBE
    p50258 ±3 ms283 ±7 ms+25.2 ms (+9.8%)MAYBE
    p75266 ±4 ms293 ±8 ms+26.5 ms (+10.0%)MAYBE
    p90277 ±4 ms305 ±8 ms+27.6 ms (+9.9%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    da631d2
    • 2023-08-14_18:22:57.022418_OdUn
    • 2023-08-14_18:22:57.025636_vznp
    • 2023-08-14_18:22:57.025647_rQzR
    • 2023-08-14_18:22:57.025653_ewsj
    • 2023-08-14_18:22:57.025659_hSYq
    • 2023-08-14_18:22:57.025799_OEkg
    • 2023-08-14_18:22:57.025807_kRei
    • 2023-08-14_18:22:57.025812_NwEI
    • 2023-08-14_18:22:57.025817_LGjx
    • 2023-08-14_18:22:57.025822_CBaI
    26e2d9a
    • 2023-08-15_07:57:40.263693_NnBA
    • 2023-08-15_07:57:40.266100_fFnY
    • 2023-08-15_07:57:40.266113_CcYC
    • 2023-08-15_07:57:40.266119_WeQd
    • 2023-08-15_07:57:40.266125_JMZR
    • 2023-08-15_07:57:40.266263_RBcP
    • 2023-08-15_07:57:40.266270_UtfE
    • 2023-08-15_07:57:40.266276_FQdD
    • 2023-08-15_07:57:40.266280_yCUz
    • 2023-08-15_07:57:40.266286_IGRp

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eKLG9NFDWC/index.html

@visumickey
Copy link
Contributor Author

/retest

@visumickey visumickey merged commit 8671998 into master Aug 15, 2023
25 checks passed
@visumickey visumickey deleted the perfDataCollectionStateForSessions branch August 15, 2023 17:58
limsaehyun pushed a commit to limsaehyun/firebase-android-sdk that referenced this pull request Sep 5, 2023
@firebase firebase locked and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants