Attempt to fix flaky storage test #4957

maneesht · 2023-04-27T22:33:07Z

No description provided.

…torage-test

github-actions · 2023-04-27T22:33:20Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2023-04-27T22:33:35Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

google-oss-bot · 2023-04-27T22:37:40Z

Coverage Report ¹

Affected Products

`firebase-storage`

Overall coverage changed from 86.24% (38e6829) to 74.63% (ce7eccd) by -11.61%.

12 individual files with coverage change

Filename	Base (`38e6829`)	Merge (`ce7eccd`)	Diff
ActivityLifecycleListener.java	74.14%	17.24%	-56.90%
ExponentialBackoffSender.java	86.00%	58.00%	-28.00%
NetworkRequest.java	87.11%	78.87%	-8.25%
ResumableUploadByteRequest.java	90.91%	86.36%	-4.55%
ResumableUploadCancelRequest.java	100.00%	0.00%	-100.00%
SmartHandler.java	92.31%	76.92%	-15.38%
StorageException.java	69.09%	63.16%	-5.93%
StorageReference.java	89.94%	73.37%	-16.57%
StorageTask.java	83.99%	63.14%	-20.85%
StorageTaskManager.java	100.00%	72.97%	-27.03%
TaskListenerImpl.java	100.00%	88.10%	-11.90%
UploadTask.java	83.50%	57.57%	-25.93%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/0ECavQlIdz.html

github-actions · 2023-04-27T22:40:51Z

Unit Test Results

  36 files +  24   36 suites +24 1m 14s ⏱️ -5s
108 tests +  61 107 ✔️ +  61 0 💤 - 1 1 ❌ +1
216 runs +122 215 ✔️ +123 0 💤 - 2 1 ❌ +1

For more details on these failures, see this check.

Results for commit c0d8b21. ± Comparison against base commit 38e6829.

This pull request removes 47 and adds 108 tests. Note that renamed tests count towards both.

com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ dismissClickListener_dismissesFiam
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ dismissTimer_onComplete_dismissesFiam
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ fiamClickListener_whenActionUrlProvided_andBrowserAvailable_opensBrowserIntent
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ fiamClickListener_whenActionUrlProvided_andChromeAvailable_opensCustomTab
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ fiamUIListener_whenFiamClicked_receivesOnFiamClick
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ firebaseInAppMessagingUIListener_whenFiamRendered_receivesOnFiamTrigger
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ impressionTimer_onComplete_firesImpressionLogAction
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ inflate_setsActionListenerToDismissFiamOnClick
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ onActivitPaused_clearsListeners
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ onActivityNewActivityStarted_displaysFiamInNewActivity
…

com.google.firebase.appcheck.debug.testing.DebugAppCheckTestHelperTest ‑ testDebugAppCheckTestHelper_withDebugProviderDefaultApp_installsDebugProvider
com.google.firebase.appcheck.debug.testing.DebugAppCheckTestHelperTest ‑ testDebugAppCheckTestHelper_withDebugProviderNamedApp_installsDebugProvider
com.google.firebase.appcheck.debug.testing.DebugAppCheckTestHelperTest ‑ testDebugAppCheckTestHelper_withDebugProvider_noPreviousProvider_installsDebugProvider
com.google.firebase.appcheck.debug.testing.FirebaseAppCheckDebugTestingRegistrarTest ‑ testGetComponents
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ advanceCachedBytes
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ advanceStreamBytes
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ bufferReachedEnd
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ bufferResize
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ readStream
com.google.firebase.storage.DeleteTest ‑ deleteBlob
…

♻️ This comment has been updated with latest results.

google-oss-bot · 2023-04-27T22:47:46Z

Size Report ¹

Affected Products

firebase-storage
Type Base (38e6829) Merge (ce7eccd) Diff
aar 115 kB 115 kB +180 B (+0.2%)
apk (release) 1.59 MB 1.59 MB -92 B (-0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/dz1L4JfVBa.html

google-oss-bot · 2023-04-28T00:08:56Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (38e6829) and the CI merge commit (ce7eccd)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 38e6829: https://storage.googleapis.com/firebase-sdk-metric-reports/jvFb2eskLZ/index.html
- ce7eccd: https://storage.googleapis.com/firebase-sdk-metric-reports/LJt8hfnjTT/index.html

Startup Times

`fire-app-check`

Device Statistics Distributions

oriole-32

Percentile	`38e6829`	`ce7eccd`	Diff	Significant (?)
p10	500 ±517 μs	665 ±961 μs	+165 μs (+33.0%)	NO
p25	523 ±535 μs	690 ±990 μs	+167 μs (+31.9%)	NO
p50	577 ±566 μs	752 ±1042 μs	+175 μs (+30.3%)	NO
p75	655 ±601 μs	882 ±1205 μs	+228 μs (+34.8%)	NO
p90	784 ±709 μs	1.09 ±1 ms	+307 μs (+39.1%)	NO

20 test runs in comparison

Commit	Test Runs
`38e6829`	2023-04-27_22:02:51.104901_scdB 2023-04-27_22:02:51.109816_njlD 2023-04-27_22:02:51.109831_baRx 2023-04-27_22:02:51.109838_MptS 2023-04-27_22:02:51.109843_Rcdp 2023-04-27_22:02:51.109849_cGlt 2023-04-27_22:02:51.109855_BFYI 2023-04-27_22:02:51.109862_ShUj 2023-04-27_22:02:51.109867_ZkfX 2023-04-27_22:02:51.109873_QIoN
`ce7eccd`	2023-04-27_23:31:55.816204_OqqG 2023-04-27_23:31:55.819068_suFJ 2023-04-27_23:31:55.819085_aJaV 2023-04-27_23:31:55.819091_cweY 2023-04-27_23:31:55.819097_QcPg 2023-04-27_23:31:55.819103_hFbD 2023-04-27_23:31:55.819109_TLqJ 2023-04-27_23:31:55.819114_WgGd 2023-04-27_23:31:55.819119_tAFk 2023-04-27_23:31:55.819126_aAxz

redfin-30

Percentile	`38e6829`	`ce7eccd`	Diff	Significant (?)
p10	1.77 ±2 ms	426 ±136 μs	-1.35 ms (-76.0%)	NO
p25	1.91 ±2 ms	464 ±175 μs	-1.45 ms (-75.7%)	NO
p50	2.14 ±3 ms	569 ±292 μs	-1.57 ms (-73.4%)	NO
p75	2.44 ±3 ms	775 ±508 μs	-1.67 ms (-68.3%)	NO
p90	2.98 ±3 ms	1.24 ±1 ms	-1.73 ms (-58.2%)	NO

20 test runs in comparison

Commit	Test Runs
`38e6829`	2023-04-27_22:02:51.104901_scdB 2023-04-27_22:02:51.109816_njlD 2023-04-27_22:02:51.109831_baRx 2023-04-27_22:02:51.109838_MptS 2023-04-27_22:02:51.109843_Rcdp 2023-04-27_22:02:51.109849_cGlt 2023-04-27_22:02:51.109855_BFYI 2023-04-27_22:02:51.109862_ShUj 2023-04-27_22:02:51.109867_ZkfX 2023-04-27_22:02:51.109873_QIoN
`ce7eccd`	2023-04-27_23:31:55.816204_OqqG 2023-04-27_23:31:55.819068_suFJ 2023-04-27_23:31:55.819085_aJaV 2023-04-27_23:31:55.819091_cweY 2023-04-27_23:31:55.819097_QcPg 2023-04-27_23:31:55.819103_hFbD 2023-04-27_23:31:55.819109_TLqJ 2023-04-27_23:31:55.819114_WgGd 2023-04-27_23:31:55.819119_tAFk 2023-04-27_23:31:55.819126_aAxz

`fire-gcs`

Device Statistics Distributions

oriole-32

Percentile	`38e6829`	`ce7eccd`	Diff	Significant (?)
p10	37.3 ±6 μs	39.2 ±3 μs	+1.92 μs (+5.2%)	NO
p25	39.8 ±7 μs	41.4 ±4 μs	+1.61 μs (+4.1%)	NO
p50	44.2 ±9 μs	45.0 ±5 μs	+834 ns (+1.9%)	NO
p75	55.6 ±12 μs	52.8 ±9 μs	-2.81 μs (-5.1%)	NO
p90	68.4 ±23 μs	62.7 ±14 μs	-5.64 μs (-8.2%)	NO

20 test runs in comparison

Commit	Test Runs
`38e6829`	2023-04-27_22:02:51.104901_scdB 2023-04-27_22:02:51.109816_njlD 2023-04-27_22:02:51.109831_baRx 2023-04-27_22:02:51.109838_MptS 2023-04-27_22:02:51.109843_Rcdp 2023-04-27_22:02:51.109849_cGlt 2023-04-27_22:02:51.109855_BFYI 2023-04-27_22:02:51.109862_ShUj 2023-04-27_22:02:51.109867_ZkfX 2023-04-27_22:02:51.109873_QIoN
`ce7eccd`	2023-04-27_23:31:55.816204_OqqG 2023-04-27_23:31:55.819068_suFJ 2023-04-27_23:31:55.819085_aJaV 2023-04-27_23:31:55.819091_cweY 2023-04-27_23:31:55.819097_QcPg 2023-04-27_23:31:55.819103_hFbD 2023-04-27_23:31:55.819109_TLqJ 2023-04-27_23:31:55.819114_WgGd 2023-04-27_23:31:55.819119_tAFk 2023-04-27_23:31:55.819126_aAxz

redfin-30

Percentile	`38e6829`	`ce7eccd`	Diff	Significant (?)
p10	90.4 ±11 μs	83.5 ±12 μs	-6.93 μs (-7.7%)	NO
p25	95.1 ±11 μs	87.0 ±13 μs	-8.08 μs (-8.5%)	NO
p50	101 ±11 μs	92.9 ±13 μs	-8.14 μs (-8.1%)	NO
p75	109 ±13 μs	103 ±16 μs	-5.63 μs (-5.2%)	NO
p90	123 ±20 μs	122 ±23 μs	-448 ns (-0.4%)	NO

20 test runs in comparison

Commit	Test Runs
`38e6829`	2023-04-27_22:02:51.104901_scdB 2023-04-27_22:02:51.109816_njlD 2023-04-27_22:02:51.109831_baRx 2023-04-27_22:02:51.109838_MptS 2023-04-27_22:02:51.109843_Rcdp 2023-04-27_22:02:51.109849_cGlt 2023-04-27_22:02:51.109855_BFYI 2023-04-27_22:02:51.109862_ShUj 2023-04-27_22:02:51.109867_ZkfX 2023-04-27_22:02:51.109873_QIoN
`ce7eccd`	2023-04-27_23:31:55.816204_OqqG 2023-04-27_23:31:55.819068_suFJ 2023-04-27_23:31:55.819085_aJaV 2023-04-27_23:31:55.819091_cweY 2023-04-27_23:31:55.819097_QcPg 2023-04-27_23:31:55.819103_hFbD 2023-04-27_23:31:55.819109_TLqJ 2023-04-27_23:31:55.819114_WgGd 2023-04-27_23:31:55.819119_tAFk 2023-04-27_23:31:55.819126_aAxz

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`38e6829`	`ce7eccd`	Diff	Significant (?)
p10	193 ±7 ms	196 ±3 ms	+3.01 ms (+1.6%)	NO
p25	199 ±7 ms	202 ±3 ms	+3.43 ms (+1.7%)	NO
p50	206 ±6 ms	210 ±4 ms	+4.11 ms (+2.0%)	NO
p75	213 ±7 ms	218 ±6 ms	+4.98 ms (+2.3%)	NO
p90	222 ±8 ms	231 ±8 ms	+8.74 ms (+3.9%)	NO

20 test runs in comparison

Commit	Test Runs
`38e6829`	2023-04-27_22:02:51.104901_scdB 2023-04-27_22:02:51.109816_njlD 2023-04-27_22:02:51.109831_baRx 2023-04-27_22:02:51.109838_MptS 2023-04-27_22:02:51.109843_Rcdp 2023-04-27_22:02:51.109849_cGlt 2023-04-27_22:02:51.109855_BFYI 2023-04-27_22:02:51.109862_ShUj 2023-04-27_22:02:51.109867_ZkfX 2023-04-27_22:02:51.109873_QIoN
`ce7eccd`	2023-04-27_23:31:55.816204_OqqG 2023-04-27_23:31:55.819068_suFJ 2023-04-27_23:31:55.819085_aJaV 2023-04-27_23:31:55.819091_cweY 2023-04-27_23:31:55.819097_QcPg 2023-04-27_23:31:55.819103_hFbD 2023-04-27_23:31:55.819109_TLqJ 2023-04-27_23:31:55.819114_WgGd 2023-04-27_23:31:55.819119_tAFk 2023-04-27_23:31:55.819126_aAxz

redfin-30

Percentile	`38e6829`	`ce7eccd`	Diff	Significant (?)
p10	234 ±4 ms	255 ±7 ms	+21.7 ms (+9.3%)	MAYBE
p25	239 ±3 ms	261 ±7 ms	+22.5 ms (+9.4%)	MAYBE
p50	246 ±4 ms	269 ±7 ms	+22.6 ms (+9.2%)	MAYBE
p75	254 ±4 ms	278 ±8 ms	+24.1 ms (+9.5%)	MAYBE
p90	263 ±6 ms	289 ±9 ms	+26.3 ms (+10.0%)	MAYBE

20 test runs in comparison

Commit	Test Runs
`38e6829`	2023-04-27_22:02:51.104901_scdB 2023-04-27_22:02:51.109816_njlD 2023-04-27_22:02:51.109831_baRx 2023-04-27_22:02:51.109838_MptS 2023-04-27_22:02:51.109843_Rcdp 2023-04-27_22:02:51.109849_cGlt 2023-04-27_22:02:51.109855_BFYI 2023-04-27_22:02:51.109862_ShUj 2023-04-27_22:02:51.109867_ZkfX 2023-04-27_22:02:51.109873_QIoN
`ce7eccd`	2023-04-27_23:31:55.816204_OqqG 2023-04-27_23:31:55.819068_suFJ 2023-04-27_23:31:55.819085_aJaV 2023-04-27_23:31:55.819091_cweY 2023-04-27_23:31:55.819097_QcPg 2023-04-27_23:31:55.819103_hFbD 2023-04-27_23:31:55.819109_TLqJ 2023-04-27_23:31:55.819114_WgGd 2023-04-27_23:31:55.819119_tAFk 2023-04-27_23:31:55.819126_aAxz

https://storage.googleapis.com/firebase-sdk-metric-reports/FK7lY6kSa7/index.html

maneesht added 3 commits April 25, 2023 15:53

WIP

a37c06b

Merge remote-tracking branch 'origin/master' into mtewani/fix-flaky-s…

04ff9f6

…torage-test

Formatted

3cf4208

google-oss-bot added the do-not-merge/work-in-progress label Apr 27, 2023

google-oss-bot added the size/XXL label Apr 27, 2023

maneesht added 2 commits April 27, 2023 15:47

Added logs

e44c2bc

Logged error code

c0d8b21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Attempt to fix flaky storage test #4957

Attempt to fix flaky storage test #4957

maneesht commented Apr 27, 2023

github-actions bot commented Apr 27, 2023 •

edited

Loading

google-oss-bot commented Apr 27, 2023

google-oss-bot commented Apr 27, 2023 •

edited

Loading

`firebase-storage`

github-actions bot commented Apr 27, 2023 •

edited

Loading

google-oss-bot commented Apr 27, 2023 •

edited

Loading

`firebase-storage`

google-oss-bot commented Apr 28, 2023

`fire-app-check`

`fire-gcs`

`timeToInitialDisplay`

Attempt to fix flaky storage test #4957

Are you sure you want to change the base?

Attempt to fix flaky storage test #4957

Conversation

maneesht commented Apr 27, 2023

github-actions bot commented Apr 27, 2023 • edited Loading

📝 PRs merging into main branch

google-oss-bot commented Apr 27, 2023

google-oss-bot commented Apr 27, 2023 • edited Loading

Coverage Report 1

Affected Products

firebase-storage

Test Logs

github-actions bot commented Apr 27, 2023 • edited Loading

Unit Test Results

google-oss-bot commented Apr 27, 2023 • edited Loading

Size Report 1

Affected Products

firebase-storage

Test Logs

google-oss-bot commented Apr 28, 2023

Startup Time Report 1

Notes

Startup Times

fire-app-check

fire-gcs

timeToInitialDisplay

github-actions bot commented Apr 27, 2023 •

edited

Loading

google-oss-bot commented Apr 27, 2023 •

edited

Loading

Coverage Report ¹

`firebase-storage`

github-actions bot commented Apr 27, 2023 •

edited

Loading

google-oss-bot commented Apr 27, 2023 •

edited

Loading

Size Report ¹

`firebase-storage`

Startup Time Report ¹

`fire-app-check`

`fire-gcs`

`timeToInitialDisplay`