Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate FIS to KTS + VC #4832

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Migrate FIS to KTS + VC #4832

wants to merge 5 commits into from

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Mar 29, 2023 •
edited
Loading

Per b/274928621,

This migrates all the FIS build scripts from Groovy to Kotlin, and from the old ext based common dep versioning to the new Version Catalog based versioning.

More specifically, this migrates the following SDKs:

  • firebase-installations
  • firebase-installations-ktx
  • firebase-installations-interop

@daymxn daymxn self-assigned this Mar 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@daymxn daymxn requested a review from rlazo March 29, 2023 18:16
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023 •
edited
Loading

Unit Test Results

   774 files  +  31     774 suites  +31   34m 57s ⏱️ + 5m 17s
4 853 tests +    1  4 832 ✔️ +    3  21 💤 ±0  0 ❌  - 2 
9 503 runs  +516  9 461 ✔️ +517  42 💤 +1  0 ❌  - 2 

Results for commit 2df959a. ± Comparison against base commit f63aa5e.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 29, 2023 •
edited
Loading

Size Report 1

Affected Products

  • firebase-config-ktx

    TypeBase (f63aa5e)Merge (eac2907)Diff
    apk (aggressive)160 kB160 kB+76 B (+0.0%)
    apk (release)1.70 MB1.71 MB+3.60 kB (+0.2%)

  • firebase-inappmessaging

    TypeBase (f63aa5e)Merge (eac2907)Diff
    apk (aggressive)698 kB699 kB+164 B (+0.0%)
    apk (release)3.95 MB3.95 MB+2.88 kB (+0.1%)

  • firebase-inappmessaging-display

    TypeBase (f63aa5e)Merge (eac2907)Diff
    apk (aggressive)1.53 MB1.53 MB+24 B (+0.0%)
    apk (release)5.21 MB5.21 MB+2.85 kB (+0.1%)

  • firebase-inappmessaging-display-ktx

    TypeBase (f63aa5e)Merge (eac2907)Diff
    apk (aggressive)1.54 MB1.54 MB+88 B (+0.0%)
    apk (release)5.59 MB5.59 MB+1.24 kB (+0.0%)

  • firebase-inappmessaging-ktx

    TypeBase (f63aa5e)Merge (eac2907)Diff
    apk (aggressive)706 kB706 kB+100 B (+0.0%)
    apk (release)4.33 MB4.34 MB+2.75 kB (+0.1%)

  • firebase-installations

    TypeBase (f63aa5e)Merge (eac2907)Diff
    aar55.2 kB55.1 kB-98 B (-0.2%)
    apk (aggressive)114 kB118 kB+4.09 kB (+3.6%)
    apk (release)1.28 MB1.29 MB+3.66 kB (+0.3%)

  • firebase-installations-interop

    TypeBase (f63aa5e)Merge (eac2907)Diff
    aar8.05 kB8.02 kB-31 B (-0.4%)
    apk (release)652 kB651 kB-424 B (-0.1%)

  • firebase-installations-ktx

    TypeBase (f63aa5e)Merge (eac2907)Diff
    apk (release)1.67 MB1.67 MB+2.50 kB (+0.2%)

  • firebase-ml-modeldownloader

    TypeBase (f63aa5e)Merge (eac2907)Diff
    apk (release)1.41 MB1.41 MB+2.78 kB (+0.2%)

  • firebase-ml-modeldownloader-ktx

    TypeBase (f63aa5e)Merge (eac2907)Diff
    apk (aggressive)176 kB176 kB-16 B (-0.0%)
    apk (release)1.79 MB1.79 MB+3.25 kB (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vwA5m1th30.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 29, 2023 •
edited
Loading

Startup Time Report 1

The report is too large (117,040 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eibfVvazO1/index.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 29, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.18% (f63aa5e) to 50.13% (eac2907) by -0.04%.

    FilenameBase (f63aa5e)Merge (eac2907)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%

  • firebase-installations

    Overall coverage changed from ? (f63aa5e) to 58.09% (eac2907) by ?.

    22 individual files with coverage change

    FilenameBase (f63aa5e)Merge (eac2907)Diff
    AutoValue_InstallationResponse.java?58.93%?
    AutoValue_PersistedInstallationEntry.java?56.98%?
    AutoValue_TokenResult.java?42.22%?
    AwaitListener.java?0.00%?
    Clock.java?0.00%?
    CrossProcessLock.java?51.85%?
    FirebaseInstallations.java?96.62%?
    FirebaseInstallationServiceClient.java?4.80%?
    FirebaseInstallationsException.java?78.57%?
    FirebaseInstallationsRegistrar.java?100.00%?
    GetAuthTokenListener.java?100.00%?
    GetIdListener.java?70.00%?
    IidStore.java?22.39%?
    InstallationResponse.java?100.00%?
    PersistedInstallation.java?97.01%?
    PersistedInstallationEntry.java?100.00%?
    RandomFidGenerator.java?20.00%?
    RequestLimiter.java?100.00%?
    StateListener.java?0.00%?
    SystemClock.java?100.00%?
    TokenResult.java?100.00%?
    Utils.java?95.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/c2fMuIoxOt.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees

@daymxn daymxn

Labels
main-merge-ack no-changelog size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daymxn @google-oss-bot @rlazo