Add DackkaPlugin tests #4508
Open
Add DackkaPlugin tests #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/appdistribution/AppDistributionRelease.html 2023-01-06 18:59:40.296208387 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/appdistribution/AppDistributionRelease.html 2023-01-06 18:52:11.464971174 +0000
@@ -21,7 +21,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code>abstract @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appdistribution/BinaryType.html">BinaryType</a></code></td>
+ <td width="40%"><code>abstract @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
<td>
<div><code><a href="/docs/reference/android/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>()</code></div>
<p>Returns the binary type for this build.</p>
@@ -54,7 +54,7 @@
<h2>Public methods</h2>
<div><a name="getBinaryType--"></a><a name="getbinarytype"></a>
<h3 class="api-name" id="getBinaryType()">getBinaryType</h3>
- <pre class="api-signature no-pretty-print">abstract @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appdistribution/BinaryType.html">BinaryType</a> <a href="/docs/reference/android/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>()</pre>
+ <pre class="api-signature no-pretty-print">abstract @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> <a href="/docs/reference/android/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>()</pre>
<p>Returns the binary type for this build.</p>
</div>
<div><a name="getDisplayVersion--"></a><a name="getdisplayversion"></a>--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/appdistribution/AppDistributionRelease.html 2023-01-06 18:59:40.308208373 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/appdistribution/AppDistributionRelease.html 2023-01-06 18:52:11.504971048 +0000
@@ -21,7 +21,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code><a href="/docs/reference/kotlin/com/google/firebase/appdistribution/BinaryType.html">BinaryType</a></code></td>
+ <td width="40%"><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
<td>
<div><code><a href="/docs/reference/kotlin/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>()</code></div>
<p>Returns the binary type for this build.</p>
@@ -54,7 +54,7 @@
<h2>Public functions</h2>
<div><a name="getBinaryType--"></a><a name="getbinarytype"></a>
<h3 class="api-name" id="getBinaryType()">getBinaryType</h3>
- <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>(): <a href="/docs/reference/kotlin/com/google/firebase/appdistribution/BinaryType.html">BinaryType</a></pre>
+ <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>(): <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></pre>
<p>Returns the binary type for this build.</p>
</div>
<div><a name="getDisplayVersion--"></a><a name="getdisplayversion"></a> |
Unit Test Results 402 files + 375 402 suites +375 18m 43s ⏱️ + 14m 39s For more details on these failures, see this check. Results for commit 73c035c. ± Comparison against base commit 72b228d. ♻️ This comment has been updated with latest results. |
Size Report 1Affected ProductsNo changes between base commit (ef311dc) and merge commit (9a2b9d8).Test Logs |
Coverage Report 1Affected Products
Test Logs |
rlazo
reviewed
Jan 5, 2023
buildSrc/src/test/kotlin/com/google/firebase/gradle/plugins/DackkaPluginTests.kt
Outdated
Show resolved
Hide resolved
|
Ping me when the javadoc changes are final. I'd like to take a quick look at them before approving the PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per b/249825782,
This adds tests to
build-src-checkfor theDackkaPlugin. These tests come with a predefined output that is expected from Dackka, and will rerun the project used to generate said output- and compare it with the expected output. You can read more about it in the documentation forDackkaPluginTests.This also adds a
testPluginsthat can be used instead of passingenablePluginTestsaround the command line. Although support remains forenablePluginTests.Example: