Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate more modules to Kotlin dsl #4455

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Migrate more modules to Kotlin dsl #4455

wants to merge 4 commits into from

Conversation

vkryachko
Copy link
Member

No description provided.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2022 •
edited
Loading

Unit Test Results

   402 files  ±0     402 suites  ±0   19m 28s ⏱️ - 52m 32s
4 756 tests ±0  4 733 ✔️ +10  22 💤 ±0  1 ❌  - 10 
4 772 runs  ±0  4 749 ✔️ +10  22 💤 ±0  1 ❌  - 10 

For more details on these failures, see this check.

Results for commit ce8c73b. ± Comparison against base commit c4395f2.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 14, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-abt

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)116 kB95.7 kB-20.0 kB (-17.3%)
    apk (release)1.27 MB706 kB-561 kB (-44.3%)

  • firebase-appcheck

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)361 kB340 kB-21.0 kB (-5.8%)
    apk (release)1.56 MB996 kB-561 kB (-36.0%)

  • firebase-appcheck-debug

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)362 kB341 kB-21.2 kB (-5.8%)
    apk (release)1.56 MB1.00e+03 kB-561 kB (-35.9%)

  • firebase-appcheck-debug-testing

    TypeBase (c4395f2)Merge (311c3f0)Diff
    aar7.27 kB7.30 kB+35 B (+0.5%)
    apk (aggressive)364 kB378 kB+14.1 kB (+3.9%)
    apk (release)1.60 MB1.64 MB+39.2 kB (+2.5%)

  • firebase-appcheck-interop

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)354 kB337 kB-17.0 kB (-4.8%)
    apk (release)1.54 MB983 kB-560 kB (-36.3%)

  • firebase-appcheck-ktx

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)369 kB367 kB-1.59 kB (-0.4%)
    apk (release)1.94 MB1.94 MB-1.76 kB (-0.1%)

  • firebase-appcheck-playintegrity

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)364 kB347 kB-17.2 kB (-4.7%)
    apk (release)1.57 MB1.01 MB-560 kB (-35.7%)

  • firebase-appcheck-safetynet

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)363 kB346 kB-17.0 kB (-4.7%)
    apk (release)1.57 MB1.01 MB-560 kB (-35.7%)

  • firebase-appdistribution

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)801 kB785 kB-15.5 kB (-1.9%)
    apk (release)2.57 MB2.01 MB-558 kB (-21.7%)

  • firebase-appdistribution-api

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)112 kB95.7 kB-15.9 kB (-14.3%)
    apk (release)1.27 MB707 kB-559 kB (-44.2%)

  • firebase-appdistribution-api-ktx

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)124 kB124 kB-163 B (-0.1%)
    apk (release)1.65 MB1.64 MB-3.22 kB (-0.2%)

  • firebase-common

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)111 kB95.0 kB-16.0 kB (-14.4%)
    apk (release)1.26 MB700 kB-560 kB (-44.5%)

  • firebase-common-ktx

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)123 kB123 kB-163 B (-0.1%)
    apk (release)1.64 MB1.64 MB-2.35 kB (-0.1%)

  • firebase-components

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)23.1 kB8.68 kB-14.4 kB (-62.4%)
    apk (release)596 kB33.9 kB-562 kB (-94.3%)

  • firebase-config

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)124 kB108 kB-16.1 kB (-13.0%)
    apk (release)1.31 MB753 kB-561 kB (-42.7%)

  • firebase-config-ktx

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)132 kB132 kB-163 B (-0.1%)
    apk (release)1.69 MB1.69 MB-2.79 kB (-0.2%)

  • firebase-crashlytics

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)242 kB226 kB-15.6 kB (-6.5%)
    apk (release)1.47 MB912 kB-558 kB (-38.0%)

  • firebase-crashlytics-ktx

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)249 kB249 kB-43 B (-0.0%)
    apk (release)1.85 MB1.85 MB-3.05 kB (-0.2%)

  • firebase-crashlytics-ndk

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive / arm64-v8a)1.40 MB1.38 MB-18.5 kB (-1.3%)
    apk (aggressive / armeabi-v7a)877 kB858 kB-18.5 kB (-2.1%)
    apk (aggressive / x86)1.38 MB1.36 MB-18.5 kB (-1.3%)
    apk (aggressive / x86_64)1.44 MB1.42 MB-18.5 kB (-1.3%)
    apk (release / arm64-v8a)2.62 MB2.06 MB-559 kB (-21.3%)
    apk (release / armeabi-v7a)2.10 MB1.54 MB-559 kB (-26.6%)
    apk (release / x86)2.60 MB2.05 MB-559 kB (-21.5%)
    apk (release / x86_64)2.67 MB2.11 MB-559 kB (-21.0%)

  • firebase-database

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)359 kB342 kB-17.0 kB (-4.7%)
    apk (release)1.72 MB1.16 MB-556 kB (-32.4%)

  • firebase-database-ktx

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)367 kB366 kB-1.51 kB (-0.4%)
    apk (release)2.10 MB2.10 MB-2.04 kB (-0.1%)

  • firebase-datatransport

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)161 kB145 kB-15.7 kB (-9.7%)
    apk (release)1.35 MB787 kB-562 kB (-41.6%)

  • firebase-decoders-json

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (release)15.3 kB15.6 kB+340 B (+2.2%)

  • firebase-dynamic-links

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)360 kB340 kB-19.9 kB (-5.5%)
    apk (release)1.56 MB997 kB-562 kB (-36.0%)

  • firebase-dynamic-links-ktx

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)367 kB367 kB-159 B (-0.0%)
    apk (release)1.94 MB1.94 MB-2.50 kB (-0.1%)

  • firebase-dynamic-module-support

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)124 kB104 kB-20.1 kB (-16.3%)
    apk (release)1.31 MB752 kB-561 kB (-42.7%)

  • firebase-encoders

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (release)15.3 kB15.6 kB+328 B (+2.1%)

  • firebase-encoders-json

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (release)20.1 kB20.4 kB+316 B (+1.6%)

  • firebase-encoders-proto

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (release)21.6 kB21.9 kB+328 B (+1.5%)

  • firebase-encoders-reflective

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (release)22.2 kB22.5 kB+316 B (+1.4%)

  • firebase-firestore

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)517 kB500 kB-17.0 kB (-3.3%)
    apk (release)3.93 MB3.37 MB-562 kB (-14.3%)

  • firebase-firestore-ktx

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)525 kB524 kB-1.49 kB (-0.3%)
    apk (release)4.31 MB4.31 MB-2.11 kB (-0.0%)

  • firebase-functions

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)399 kB383 kB-15.9 kB (-4.0%)
    apk (release)1.81 MB1.25 MB-561 kB (-30.9%)

  • firebase-functions-ktx

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)408 kB408 kB-159 B (-0.0%)
    apk (release)2.19 MB2.19 MB-3.58 kB (-0.2%)

  • firebase-inappmessaging

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)696 kB680 kB-15.6 kB (-2.2%)
    apk (release)3.95 MB3.39 MB-561 kB (-14.2%)

  • firebase-inappmessaging-display

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)1.53 MB1.51 MB-15.6 kB (-1.0%)
    apk (release)5.21 MB4.64 MB-564 kB (-10.8%)

  • firebase-inappmessaging-display-ktx

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)1.54 MB1.54 MB+77 B (+0.0%)
    apk (release)5.59 MB5.59 MB-2.67 kB (-0.0%)

  • firebase-inappmessaging-ktx

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)704 kB704 kB-7 B (-0.0%)
    apk (release)4.33 MB4.33 MB-3.53 kB (-0.1%)

  • firebase-installations

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)116 kB96.6 kB-19.9 kB (-17.1%)
    apk (release)1.28 MB723 kB-559 kB (-43.6%)

  • firebase-installations-ktx

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)125 kB124 kB-159 B (-0.1%)
    apk (release)1.67 MB1.66 MB-3.35 kB (-0.2%)

  • firebase-messaging

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)463 kB448 kB-15.5 kB (-3.3%)
    apk (release)1.72 MB1.16 MB-559 kB (-32.5%)

  • firebase-messaging-directboot

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)464 kB448 kB-15.5 kB (-3.3%)
    apk (release)1.72 MB1.16 MB-559 kB (-32.5%)

  • firebase-messaging-ktx

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)471 kB471 kB+37 B (+0.0%)
    apk (release)2.10 MB2.10 MB-2.51 kB (-0.1%)

  • firebase-ml-modeldownloader

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)166 kB150 kB-15.7 kB (-9.5%)
    apk (release)1.41 MB848 kB-559 kB (-39.7%)

  • firebase-ml-modeldownloader-ktx

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)174 kB174 kB+57 B (+0.0%)
    apk (release)1.79 MB1.79 MB-2.88 kB (-0.2%)

  • firebase-perf

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)1.05 MB1.04 MB-15.6 kB (-1.5%)
    apk (release)3.05 MB2.49 MB-556 kB (-18.3%)

  • firebase-perf-ktx

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)1.06 MB1.06 MB-27 B (-0.0%)
    apk (release)3.43 MB3.43 MB-2.74 kB (-0.1%)

  • firebase-segmentation

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)117 kB97.1 kB-19.8 kB (-16.9%)
    apk (release)1.29 MB730 kB-560 kB (-43.4%)

  • firebase-storage

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)359 kB337 kB-21.2 kB (-5.9%)
    apk (release)1.59 MB1.03 MB-559 kB (-35.2%)

  • firebase-storage-ktx

    TypeBase (c4395f2)Merge (311c3f0)Diff
    apk (aggressive)366 kB365 kB-1.50 kB (-0.4%)
    apk (release)1.97 MB1.97 MB-2.92 kB (-0.1%)

  • transport-api

    TypeBase (c4395f2)Merge (311c3f0)Diff
    aar6.74 kB6.74 kB-1 B (-0.0%)
    apk (release)14.9 kB15.2 kB+316 B (+2.1%)

  • transport-backend-cct

    TypeBase (c4395f2)Merge (311c3f0)Diff
    aar53.6 kB53.5 kB-63 B (-0.1%)
    apk (aggressive)58.2 kB58.4 kB+244 B (+0.4%)
    apk (release)105 kB106 kB+200 B (+0.2%)

  • transport-runtime

    TypeBase (c4395f2)Merge (311c3f0)Diff
    aar180 kB179 kB-201 B (-0.1%)
    apk (aggressive)44.0 kB43.7 kB-308 B (-0.7%)
    apk (release)83.5 kB83.6 kB+120 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mD4Rta1lYE.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 14, 2022 •
edited
Loading

Startup Time Report 1

The report is too large (117,085 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/b3RKL9WrKz/index.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.19% (c4395f2) to 50.22% (311c3f0) by +0.03%.

    FilenameBase (c4395f2)Merge (311c3f0)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    QueryParams.java90.36%89.76%-0.60%

  • firebase-firestore

    Overall coverage changed from 44.53% (c4395f2) to 44.52% (311c3f0) by -0.00%.

    FilenameBase (c4395f2)Merge (311c3f0)Diff
    SetMutation.java97.22%94.44%-2.78%

  • firebase-messaging

    Overall coverage changed from ? (c4395f2) to 85.14% (311c3f0) by ?.

    41 individual files with coverage change

    FilenameBase (c4395f2)Merge (311c3f0)Diff
    AutoProtoEncoderDoNotUseEncoder.java?98.17%?
    ByteStreams.java?59.72%?
    CommonNotificationBuilder.java?90.78%?
    Constants.java?92.86%?
    DisplayNotification.java?91.38%?
    EnhancedIntentService.java?76.60%?
    ExecutorFactory.java?0.00%?
    FcmBroadcastProcessor.java?93.33%?
    FcmExecutors.java?80.00%?
    FcmLifecycleCallbacks.java?89.29%?
    FirebaseInstanceIdReceiver.java?72.73%?
    FirebaseMessaging.java?75.77%?
    FirebaseMessagingRegistrar.java?100.00%?
    FirebaseMessagingService.java?94.03%?
    GmsRpc.java?83.15%?
    ImageDownload.java?93.33%?
    MessagingAnalytics.java?81.38%?
    MessagingClientEvent.java?93.58%?
    MessagingClientEventExtension.java?76.47%?
    Metadata.java?57.14%?
    NotificationParams.java?98.71%?
    PoolableExecutors.java?29.17%?
    ProtoEncoderDoNotUse.java?50.00%?
    ProxyNotificationInitializer.java?93.75%?
    ProxyNotificationPreferences.java?88.89%?
    RemoteMessage.java?95.48%?
    RemoteMessageCreator.java?88.89%?
    RequestDeduplicator.java?90.00%?
    SendException.java?100.00%?
    ServiceStarter.java?87.50%?
    SharedPreferencesQueue.java?98.65%?
    Store.java?74.19%?
    SyncTask.java?70.83%?
    ThreadPriority.java?100.00%?
    TopicOperation.java?90.00%?
    TopicsStore.java?100.00%?
    TopicsSubscriber.java?89.47%?
    TopicsSyncTask.java?53.33%?
    WakeLockHolder.java?95.92%?
    WithinAppServiceBinder.java?90.91%?
    WithinAppServiceConnection.java?84.15%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LfyvZsuQs4.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkryachko @google-oss-bot