-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ywmei/serialization feature branch #3951
Open
ywmei-brt1
wants to merge
10
commits into
main
Choose a base branch
from
ywmei/serialization-feature-branch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add annotations and provide comments * change Kotlin serialization depenencies from Json to Core * clean gitignore file and merge all annotations into one file * file name change for ktx annotation file * Replace {@code } with kotlin inline markup [], remove self-ref Ref: go/androidx-kdoc-guidelines#do-not-link-to-the-same-identifier-inside-documentation * generated new API text file Co-authored-by: y5mei <[email protected]>
* Upgrade kotlin version to 1.6.20 * Upgrade dagger in protoc-gen-firebase-encoders. * Filter out only release component. * Add explanation.
* Add annotations and provide comments * change Kotlin serialization depenencies from Json to Core * clean gitignore file and merge all annotations into one file * file name change for ktx annotation file * Basic Encoder handle Object & List * run unit test in parallel and ignore */bin/ folder * add kotlin doc, added more test, and remove unsued descriptor parameter from encoder * removed tailing comma in the Encoder's constructor * Replace {@code } with kotlin inline markup [], remove self-ref Ref: go/androidx-kdoc-guidelines#do-not-link-to-the-same-identifier-inside-documentation * add copy right * generated new API text file * changed test with Truth * new map encoder * Supporting Encoder with CallBack functions * fix typo * remove index from list encoder Co-authored-by: y5mei <[email protected]>
* update java gradle file to include Ktx dependency * convert Java annotations to Ktx and provide unti tests * abstract serializer and encoder for Java converted classes * make java class @serializable and provide serializers, encoders, and test utils * convert ktx classes to Java * change test util class name and fix comments * add a line at the end of gradle file * removed extra test from firebase-firestore.gradle * update proguard file * modified proguard.txt * more try with proguard * format change * update proguard.txt * new line at the end of each file
* Add annotations and provide comments * change Kotlin serialization depenencies from Json to Core * clean gitignore file and merge all annotations into one file * file name change for ktx annotation file * Basic Encoder handle Object & List * run unit test in parallel and ignore */bin/ folder * add kotlin doc, added more test, and remove unsued descriptor parameter from encoder * removed tailing comma in the Encoder's constructor * Replace {@code } with kotlin inline markup [], remove self-ref Ref: go/androidx-kdoc-guidelines#do-not-link-to-the-same-identifier-inside-documentation * add copy right * generated new API text file * draft of documentId annotation and servertimestamp * move test util to firebase firestore pacakge * changed test with Truth * before refactor * annotations for 1st review * modified the logic for build CurrentElementToEncode Obj, and provide unit test for testUtil * 1st implementation of component registrar * add integration test * add copyrights * working with sealed class now * provide a set of MapEncoder * change to support() * add more Java doc * polished Kotlin doc and Java doc * update java gradle file to include Ktx dependency * convert Java annotations to Ktx and provide unti tests * abstract serializer and encoder for Java converted classes * make java class @serializable and provide serializers, encoders, and test utils * convert ktx classes to Java * change test util class name and fix comments * add a line at the end of gradle file * new integration test method wip * removed extra test from firebase-firestore.gradle * a very dangerous change * update proguard file * modified proguard.txt * more try with proguard * before change base branch to [support ktx in java] * remove extra imports in test util * format change * update for PR * update integration test with high order function * add empty line at the end of gradle.properties * change import order * fix a typo in Ktx doc * change test util method name * fix a break for AccessHelper Co-authored-by: y5mei <[email protected]>
* Add annotations and provide comments * change Kotlin serialization depenencies from Json to Core * clean gitignore file and merge all annotations into one file * file name change for ktx annotation file * Basic Encoder handle Object & List * run unit test in parallel and ignore */bin/ folder * add kotlin doc, added more test, and remove unsued descriptor parameter from encoder * removed tailing comma in the Encoder's constructor * Replace {@code } with kotlin inline markup [], remove self-ref Ref: go/androidx-kdoc-guidelines#do-not-link-to-the-same-identifier-inside-documentation * add copy right * generated new API text file * draft of documentId annotation and servertimestamp * move test util to firebase firestore pacakge * changed test with Truth * before refactor * annotations for 1st review * modified the logic for build CurrentElementToEncode Obj, and provide unit test for testUtil * 1st implementation of component registrar * add integration test * add copyrights * working with sealed class now * provide a set of MapEncoder * change to support() * add more Java doc * basic decoder * polished Kotlin doc and Java doc * update Kotlin doc * update java gradle file to include Ktx dependency * convert Java annotations to Ktx and provide unti tests * abstract serializer and encoder for Java converted classes * make java class @serializable and provide serializers, encoders, and test utils * convert ktx classes to Java * decoder can work with Ktx 1.3.72 and Gradle 6.9 * change test util class name and fix comments * add a line at the end of gradle file * update kotlin docs * new integration test method wip * removed extra test from firebase-firestore.gradle * a very dangerous change * update proguard file * modified proguard.txt * more try with proguard * before change base branch to [support ktx in java] * remove extra imports in test util * format change * changed all assertThrow to Truth * change as pre code review * remove @RunWith(), make para name short * update for PR * add runwith junit4 * update integration test with high order function * add empty line at the end of gradle.properties * change import order * fix a typo in Ktx doc * simplify unit test * change format * fix typo * change test util method name * fix a break for AccessHelper * repalce @before with top-level private var * data class to help calculate checkNUllMark Co-authored-by: y5mei <[email protected]>
* Add annotations and provide comments * change Kotlin serialization depenencies from Json to Core * clean gitignore file and merge all annotations into one file * file name change for ktx annotation file * Basic Encoder handle Object & List * run unit test in parallel and ignore */bin/ folder * add kotlin doc, added more test, and remove unsued descriptor parameter from encoder * removed tailing comma in the Encoder's constructor * Replace {@code } with kotlin inline markup [], remove self-ref Ref: go/androidx-kdoc-guidelines#do-not-link-to-the-same-identifier-inside-documentation * add copy right * generated new API text file * draft of documentId annotation and servertimestamp * move test util to firebase firestore pacakge * changed test with Truth * before refactor * annotations for 1st review * modified the logic for build CurrentElementToEncode Obj, and provide unit test for testUtil * 1st implementation of component registrar * add integration test * add copyrights * working with sealed class now * provide a set of MapEncoder * change to support() * add more Java doc * basic decoder * polished Kotlin doc and Java doc * update Kotlin doc * update java gradle file to include Ktx dependency * convert Java annotations to Ktx and provide unti tests * abstract serializer and encoder for Java converted classes * make java class @serializable and provide serializers, encoders, and test utils * convert ktx classes to Java * decoder can work with Ktx 1.3.72 and Gradle 6.9 * change test util class name and fix comments * add a line at the end of gradle file * update kotlin docs * new integration test method wip * removed extra test from firebase-firestore.gradle * a very dangerous change * update proguard file * modified proguard.txt * more try with proguard * before change base branch to [support ktx in java] * remove extra imports in test util * format change * changed all assertThrow to Truth * change as pre code review * remove @RunWith(), make para name short * update for PR * add runwith junit4 * update integration test with high order function * add empty line at the end of gradle.properties * change import order * fix a typo in Ktx doc * simplify unit test * change format * add support to annotaitons * remove extra logic * fix typo * change test util method name * merge change from parent * remove todos * throw exception directly after if * Ywmei/handle annotation during decoding (#3913) * support documentId and servertiemstamp annotation with decoder * change method name * add support for throwOnExtraProperties * decoder all done * update format * changed abstract decoder class's name * share annotations between java and kotlin (#3922) * share annotations between java and kotlin * deleted extra files and fixed the annotation target * get ktx Target.PROPERTY annotations from getXxx$Annotation() * fix typo * remove retention * fix some tests * provide more comments for synthetic method * support transaction, writebatch, query (#3923) * support transaction, writebatch, querry * provide invoke test util * fix typo * remove invoke() test util * remove gson dependency * provides more tests (#3936) Co-authored-by: y5mei <[email protected]>
Size Report 1Affected Products
Test Logs
Notes |
/retest |
@ywmei-brt1: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.