Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exception when registering too many receivers in Crashlytics. #2504

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Mar 12, 2021

Handle exception when registering too many receivers in Crashlytics. This happens when getting the battery state, and it only affects some devices and some versions of Android.

Tested by unit tests, and manually by fudging with the emulator.

Fixes #2171

@googlebot googlebot added the cla: yes Override cla label Mar 12, 2021
@mrober mrober requested a review from mrichards March 12, 2021 15:53
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (03aa092) and head commit (65ea945c).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (65ea945c) is created by Prow via merging commits: 03aa092 d1b3837.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-crashlytics

    Type Base (03aa092) Head (65ea945c) Diff
    aar 325 kB 325 kB +152 B (+0.0%)
    apk (aggressive) 192 kB 192 kB +64 B (+0.0%)
    apk (release) 818 kB 818 kB +100 B (+0.0%)

Test Logs

Notes

Head commit (65ea945c) is created by Prow via merging commits: 03aa092 d1b3837.

Copy link
Contributor

@mrichards mrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mrober mrober merged commit 352ac58 into master Mar 12, 2021
@mrober mrober deleted the crashlytics-registerReceiver branch March 12, 2021 16:12
@firebase firebase locked and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.IllegalStateException: Too many receivers, total of 1000
4 participants