Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate firebase-crashlytics SDK to FIS #1760

Merged
merged 4 commits into from
Jul 8, 2020
Merged

Migrate firebase-crashlytics SDK to FIS #1760

merged 4 commits into from
Jul 8, 2020

Conversation

adamvduke
Copy link
Contributor

No description provided.

@adamvduke adamvduke requested a review from mrwillis21 July 6, 2020 18:33
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 6, 2020 •
edited
Loading

Coverage Report

Affected SDKs

No changes between base commit (be99c93) and head commit (96267bbf).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (96267bbf) is created by Prow via merging commits: be99c93 2061b2d.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 6, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-crashlytics

    Type Base (be99c93) Head (96267bbf) Diff
    aar 410 kB 409 kB -416 B (-0.1%)
    apk (aggressive) 549 kB 324 kB -226 kB (-41.1%)
    apk (debug) 1.61 MB 1.28 MB -336 kB (-20.8%)
    apk (release) 1.35 MB 1.04 MB -310 kB (-23.0%)

  • firebase-installations

    Type Base (be99c93) Head (96267bbf) Diff
    aar 58.2 kB 58.2 kB +3 B (+0.0%)

  • transport-runtime

    Type Base (be99c93) Head (96267bbf) Diff
    apk (debug) 82.5 kB 82.5 kB -1 B (-0.0%)

Test Logs

Notes

Head commit (96267bbf) is created by Prow via merging commits: be99c93 2061b2d.

@googlebot googlebot added the cla: yes Override cla label Jul 7, 2020
mrwillis21
mrwillis21 approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@mrwillis21 mrwillis21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor requests, but otherwise LGTM.

...tics/src/androidTest/java/com/google/firebase/crashlytics/internal/common/IdManagerTest.java Outdated Show resolved Hide resolved
...tics/src/androidTest/java/com/google/firebase/crashlytics/internal/common/IdManagerTest.java Outdated Show resolved Hide resolved
@adamvduke adamvduke merged commit 04a9e0c into master Jul 8, 2020
@adamvduke adamvduke deleted the adamvduke/crashlytics-use-fis-api branch July 8, 2020 16:09
@firebase firebase locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrwillis21 mrwillis21 mrwillis21 approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamvduke @google-oss-bot @mrwillis21 @googlebot