Fix OverlappingFileLockException. #1536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access the data shared by multiple threads only after acquiring cross-process and multi-thread safe locks.
Coverage ReportAffected SDKsNo changes between base commit (9eb88b1) and head commit (03cc38ba). Test Logs
NotesHTML coverage reports can be produced locally with Head commit (03cc38ba) is created by Prow via merging commits: 9eb88b1 dc9cb81. |
Binary Size ReportAffected SDKsNo changes between base commit (9eb88b1) and head commit (03cc38ba). Test Logs
NotesHead commit (03cc38ba) is created by Prow via merging commits: 9eb88b1 dc9cb81. |
andirayo
approved these changes
May 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1519.
Background: We split the network calls to FIS Servers onto a separate thread. We need to persist the response received from the servers, we were accessing the data without acquiring the thread/process locks. Hence causing OFLE.
OverlappingFileLockException is thrown when an attempt to acquire a lock on a region of a file that overlaps a region already locked by the same Java virtual machine, or when another thread is already waiting to lock an overlapping region of the same file.
Also, updating version file to represent the correct version.