-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OverlappingFileLockException crashes with up to date libraries versions #1519
Comments
I found a few problems with this issue:
|
@JeremyR34 : Thank you for the bug report! It's late now in the Bay Area, but we will look into this tomorrow! |
@JeremyR34 : Correct me if I'm wrong: You report 3 crashes.
Case [A] indeed looks identical to an issue we have fixed in the past (as you pointed out yourself: #1234). Are you sure that this exception was correctly attributed to the version numbers you list in the description? Is it possible that the exceptions happened to older versions of your app? |
@JeremyR34 : We will fix this issue by catching |
This issue should be fixed with #1521. |
I'm sure of the versions, the issue starts happening on a new release rollout. That's why I was surprised to find an old fix related to this. I reverted my libraries versions on a new update and the issue is gone. Side note: you give me a release update, but how to check if a particular fix is included in a release. I wanted to check when and if the #1234 has been released but did not find this info. On the https://firebase.google.com/support/release-notes/android page there is only a resume but not full details. |
@JeremyR34 : fyi: I reopened the issue and we will look into this on Monday. |
No I don't think so. I have less |
@JeremyR34 , thanks a lot. That's very helpful! |
@JeremyR34, can you confirm that the Here are instructions how to publish with the latest Github version of a Firebase SDK: |
I'm sorry but unfortunately I can't for now. My only way to know if it is fixed is to release a new version of my app, and waiting for crashes to appear. Next release is not already planned and I don't want to try it before and put more users at risk of crashes until that. |
Understood. |
I don't know if it was gracefully handled by the SDK but I suppose it was not; usually when crashes are logged in the Google Play Console they are real crashes on user devices. |
@JeremyR34 Can you please update your app to use the latest version of firebase-messaging:20.2.0 which contains the fix for this issue? |
I will. I should release a new version in the next few days so I will be able to try the fix. |
Unfortunately the new version does not completely fix the issue. I found 2 different stack traces but issue seems to be always there:
|
I do not call FirebaseInstanceID delete method either. |
Thanks for the confirmation. I tried but couldn't reproduce this issue with the latest version of firebase-installations library, I will need some more details pertaining to your app.
|
It looks like a tricky bug to reproduce.
|
Hi @ankitaj224. My answers are identical to @JeremyR34. My app does not have multiple processes. My app does not initialize Firebase using multiple projects. |
Hi @ankitaj224. I would like to provide the following information regarding my recent experience with this OverlappingFileLockException error. Maybe it will help in finding its resolution. I have one project (Project A) with the following dependencies and versions: I released and encountered the error in question. I reverted Project A to now have the following dependencies and versions: I released. It has been some weeks and so far I have not encountered the error in question. I have another project (Project B) However, it has been a week since I released Project B and so far I have not encountered the error in question. Both projects have users using Android 7 and 8. Important to note Project A is used far more than Project B. For some reason the same dependencies and versions in Project A give this OverlappingFileLockException error but in Project B do not. Hopefully this information is of some assistance |
@hramchandani This is an interesting finding. Thank you so much for reporting an update. Also, I highly appreciate your patience with this issue, it has been difficult bug to reproduce. What we know so far:
Do you call FirebaseInstanceId.getInstance().getId() in either of your project A/ B explicitly? FYI: This issue will take a while to figure out due to the complexity in reproducing this issue & my work on wrapping up other high priority issues. But I am definitely brainstorming on how to reproduce this issue. Thanks. |
Hi @ankitaj224 I understand it is a difficult error to reproduce and resolve. Yes. I do call FirebaseInstanceId.getInstance().getId() in Project A, which is the project which gives the OverlappingFileLockException error. I call the addOnCompleteListener to get an updated device token. I do not call it in Project B because I have not updated that project as yet. It still uses FirebaseInstanceId.getInstance().getToken() to get an updated device token. |
For information I do not call FirebaseInstanceId.getInstance().getId() in my projects. |
Ah, I see. That rules out another possibility because Jeremy's projects don't call getId. I will try & spend some more time to reproduce this issue. I will keep this thread posted on my progress. |
I have the same problem. and FirebaseInstanceId is called in my projects like the flowing code.
public void reportFcmDaily() {
try {
FirebaseInstanceId.getInstance().getInstanceId()
.addOnCompleteListener(task -> {
if (!task.isSuccessful()) {
return;
}
String token = task.getResult().getToken();
if (!TextUtils.isEmpty(token)) {
// upload task
}
});
} catch (Exception e) {
}
} |
Hi. I am experiencing the same issue with the following implementations: implementation 'com.google.firebase:firebase-analytics:17.5.0' I see it fixed in com.google.firebase:firebase-installations:16.3.1, but not work. |
@ankitaj224 Any update? |
@roberto-lem Thanks for reaching & confirming that this issue persists in the latest versions as well. If you had any success reproducing this issue, please share the steps. Also, What % of app crashes are due to this error? @JeremyR34 Unfortunately, no. I couldn't make progress on this issue due to other high-priority tasks. Last I tried reproducing this for a multi-threaded, multi-process Firebase app, I couldn't. As its clear from multiple reports this issue still persists in the latest versions & is specific to Android 7 & 8. I`ll internally reach out to the Android build team to see if they can help. I would request you to please hold on updating till I confirm on what's going on & if we have a fix specific to these Android Versions. Extremely sorry for the inconvenience & late replies. |
Any update about this issue? Already crashed about 3000+ now, any firebase compents we used all updated to the lastest version, but issue still there.
|
I saw a fix in firebase-installations:16.3.1 that try to catch the error but actually failed? the OverlappingFileLockException not match IOException or Error. |
I am forced to postpone the migration to the new version of Crashlytics because of this bug. @ankitaj224 can you check @luhongwu proposal, it seems a quick fix that we can test early, don't you think? |
@JeremyR34 Really sorry for the inconvenience. I have raised the priority of this issue with my team and should have some update by early next week. I understand that catching the OverlappingFileLockException is a quick fix. However, we need to evaluate what the impact of catching this exception will be on the Firebase Installation service. Thanks for sharing the timelines with us. I will keep that in mind when addressing this issue. |
Hi @JeremyR34 , @luhongwu , @roberto-lem and others, Do any of you have an Android bug report for this crash from the user device that you can share with us? This will help us formalize & confirm the theory on what's causing this crash. Thanks, |
I don't sorry. |
Sorry, i dit not |
Hi @ankitaj224. I know you are working on this issue so I apologize for asking for another update so quickly. I want to go back to @JeremyR34 comment where he states "I am forced to postpone the migration to the new version of Crashlytics because of this bug. Apparently we have to update our applications before November 15, 2020 otherwise we will no longer receive crash reports afterwards". Is there any workaround we can perform to ensure we continue to receive crash reports but maybe update to an intermediate version so this bug does not occur? Thank you for any assistance you can provide. |
Thanks for reaching out. I have already submitted a quick fix into Firebase Installations library that should avoid the occurrence of this bug. However, this fix will be made available externally as part of November 12, 2020 release. Would that suffice as for the workaround you were looking for? |
Hi @ankitaj224, do you confirm your fix has been released yesterday? Can you please confirm the lib version? |
For information, I released an update with com.google.firebase:firebase-bom:26.1.0, and the issue seems to be fixed, I don't have this crash occuring anymore. |
Hi @JeremyR34 , Thanks for confirming about the fix. Sorry, I was on vacation & couldn't confirm earlier that the fix has been released as part of latest firebase-installations v 16.3.4 I will be closing this issue. Please feel free to reopen if anyone continues to see this issue. Thanks, |
Hi @ankitaj224 ,
|
Hi @CCCCoder Thanks for reaching out. Could you please attach some stack traces of the crash you are noticing using the latest Firebase installation version 16.3.4. It will be helpful in nailing down what's happening. I find it strange that catching the OverlappingFileLockException isn't working. |
com.google.firebase:firebase-core 17.4.0
com.google.firebase:firebase-analytics 17.4.0
com.google.firebase:firebase-messaging 20.1.6
com.crashlytics.sdk.android:crashlytics 2.10.1
com.google.firebase:firebase-dynamic-links 19.1.0
com.google.firebase:firebase-database 19.3.0
com.google.firebase:firebase-config 19.1.4
Describe the problem
After releasing a new version ni production with up to date Firebase libraries we have many new crashes (Google Play developer console & Firebase Crashlytics).
Steps to reproduce:
Up-to-date libraries versions.
Notes
Relevant Code:
Another kind of new crashes we have that seems also related (FirebaseInstallations):
The text was updated successfully, but these errors were encountered: