Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Support for RSL866T #56

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

added Support for RSL866T #56

wants to merge 3 commits into from

Conversation

aeinstein
Copy link

Hi, I redo the implementation with backward compatibility (minimum changes to your structure).
I can't test the default RSL remote, cause I don't have one.
Tested:

  • autocreate for RSL866T remotecontrol
  • manual create
  • state change
    Module is in use in our SmartHome

@sidey79
Copy link
Collaborator

sidey79 commented Jan 5, 2023

I'll try to get some testdata so that we can verify the behaviour.

@sidey79
Copy link
Collaborator

sidey79 commented Jan 5, 2023

@aeinstein

I got some reference data and generated tests out of them.

I think there is a change in on/off code calculation which leads to serval test failures.

Some other tests are failing, because channel is now optional which wasn't before, so we need to adapt those tests a little bit.

@aeinstein
Copy link
Author

Hi, sorry for long waiting:
yes I changed the output from open/close to on/off because its more general and my Lamps don't have Open/Close ;-)
What should we do? Make it backward compatible ? Or can we change the behavior on different type settings?

@sidey79
Copy link
Collaborator

sidey79 commented Feb 28, 2023

Hi, sorry for long waiting: yes I changed the output from open/close to on/off because its more general and my Lamps don't have Open/Close ;-) What should we do? Make it backward compatible ? Or can we change the behavior on different type settings?

I think the on/open off/close thing isn't the main issue.
There are other things, which causes the test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants