Fluent: Adding Resource Key to TabItem and TabControl styles #10116
+17
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to release/9.0 |
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
|
Started backporting to release/9.0: https://github.com/dotnet/wpf/actions/runs/12027907446 |
dotnet-policy-service
bot
added
the
PR
dipeshmsft
approved these changes
Nov 26, 2024
|
/cc @robert-abeo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a workaround for: #10054
Description
The changes here add a
DefaultTabControlStyleandDefaultTabItemStylein Fluent styles.Customer Impact
Provides a way to use
BasedOnwhen overriding tab control styles in Fluent theme. This is also a part of our initiative to have consistent theme style, and resource key value.Regression
None
Testing
Local Build Pass
Sample Application Testing
Testing the Gallery Application
Risk
Low, simply adding a resource key to the existing style.
Microsoft Reviewers: Open in CodeFlow