Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to loading .NET 8 date strings #26033

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Fall back to loading .NET 8 date strings #26033

merged 2 commits into from
Nov 26, 2024

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented Nov 21, 2024

Description of Change

This has to do with the different implementations of the preferences API on Windows depending on packaged or unpackaged.

  • The .NET 8 template was packaged
  • The .NET 9 template was unpackaged

The implementation differs:

  • packaged uses the ApplicationDataContainer APIs and stores as long and cannot be retrieved as string
  • unpackaged uses a string dictionary that is serialized to a file

The real change comes in at #22815 where that PR had this line: https://github.com/dotnet/maui/pull/22815/files#diff-6ed591e38dc7754551705bf5bb96f992115c384d19166e8dcda76267e177fb0cR196-R197

In .NET 8 everything was a "ToString" system for unpackaged. In .NET 9 there is now a ToBinary.

Issues Fixed

Fixes #25930

@mattleibow mattleibow requested a review from a team as a code owner November 21, 2024 19:08
@mattleibow mattleibow added the area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info label Nov 21, 2024
@PureWeen PureWeen added this to the .NET 9 SR2 milestone Nov 21, 2024
Foda
Foda previously approved these changes Nov 21, 2024
jsuarezruiz
jsuarezruiz previously approved these changes Nov 22, 2024
@mattleibow mattleibow dismissed stale reviews from jsuarezruiz and Foda via 5c68b3c November 23, 2024 05:42
@jfversluis jfversluis merged commit 1f7a986 into main Nov 26, 2024
104 checks passed
@jfversluis jfversluis deleted the dev/dt-compat branch November 26, 2024 10:20
@samhouts samhouts added fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
@renovate renovate bot mentioned this pull request Jan 14, 2025
1 task
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Preferences DateTime Storage Issues
7 participants