Skip to content

Conversation

@chriscollins3456
Copy link
Collaborator

Saw an issue where a group was added to the actor field for a link in the intitutionalMemory aspect but our graphql API was only expecting users and had that hard defined. I resolved this by deprecating the old field that only allows users, and created a new actor field that is a union of CorpUser and CorpGroup and then swapped out all the references in the UI.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 22, 2024
@chriscollins3456 chriscollins3456 merged commit 41f7fc9 into datahub-project:master Nov 25, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants