remove buggy and redundant test #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 5, 2022
…fig-os-ubuntu-18-04-r-release-test-src-test-postgres-covr-true-desc-Postgres-with-covr
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1448 (comment)
the test "Standard learning from MSSQL (schema 'dbo') or Postgres (schema 'public') and get_src_tbl_names() works?" was actually duplicated. The second version (https://github.com/cynkra/dm/blob/main/tests/testthat/test-learn.R#L44-L108) worked as intended, but for Postgres all sorts of additional (system?) tables are also included which made it necessary to manually subset the dm-tables in the test (was already like that all along; seems we neglected to turn this bug into an issue when we noticed it).
Since it will be solved in #1448, we should remove the subsetting in the test in this PR.