[computes] fixed session-type extraction for connectors #3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitsrivastava
requested review from
wing2fly,
athithyaaselvam,
agl29,
Harshg999 and
ranade1
Harshg999
approved these changes
May 1, 2024
amitsrivastava
force-pushed
the
dev/amit/fix_session_types_for_connectors
branch
from
b3ceb92
to
3eff591
Compare
agl29
reviewed
May 22, 2024
| @@ -44,6 +42,9 @@ | |||
| from notebook.connectors.base import Api, QueryError, QueryExpired, OperationTimeout, OperationNotSupported, _get_snippet_name, Notebook, \ | |||
| get_interpreter, patch_snippet_for_connector | |||
|
|
|||
| from future import standard_library | |||
| standard_library.install_aliases() | |||
There was a problem hiding this comment.
@agl29 I have not removed it and nothing seem to have crashed this far. We have these install_aliases() at several places in our code base. We need to see if we really need them anymore.
There was a problem hiding this comment.
I guess we don't need them, may be it was required for python2 based Hue.
The problem is that connector based query execution is not able to reuse session to fetch results. The frontend is sending the correct session_id but our session fetching logic got broken when the computes was implemented. we are now looking for the session_type from compute['name'] for computes, connector['name'] for connector and then snippets['type'] for old config file based hive/impala sessions. A related change is to make use of session for get_log and check_status calls if the frontend is sending it. Rest is some ruff and other refactoring.
amitsrivastava
force-pushed
the
dev/amit/fix_session_types_for_connectors
branch
from
f8b4602
to
f292cb3
Compare
agl29
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that connector based query execution is not able to
reuse session to fetch results. The frontend is sending the correct
session_id but our session fetching logic got broken when the computes
was implemented. we are now looking for the session_type from
compute['name'] for computes, connector['name'] for connector and
then snippets['type'] for old config file based hive/impala sessions.
A related change is to make use of session for get_log and check_status
calls if the frontend is sending it.
Rest is some ruff and other refactoring.