feat: Add conversation store #849
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/chatwoot-mobile-app into feat/conversation-store
muhsin-k
changed the title
pranavrajs
reviewed
Nov 28, 2024
| return; | ||
| } | ||
|
|
||
| const conversation = state.entities[conversationId]; |
There was a problem hiding this comment.
This is a mistake we made in the dashboard. Let us try to avoid it here. Move the messages to a message store
{ messageId: messageObject } format. To get the messages in order, we could get all message by conversationId. Adding a new message or updating message becomes easier this way.
pranavrajs
reviewed
Nov 28, 2024
Comment on lines
+101
to
+106
| const { conversationId, lastActivityAt } = action.payload; | ||
| const conversation = state.entities[conversationId]; | ||
| if (!conversation) { | ||
| return; | ||
| } | ||
| conversation.lastActivityAt = lastActivityAt; |
There was a problem hiding this comment.
Why is it a separate action, why don't we use the updateConversation option.
muhsin-k
changed the title
…/chatwoot-mobile-app into feat/conversation-store
|
Some files are missing after the rebase. I will create separate PR. |
|
@muhsin-k let me know once the new PR is up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversation slice manages conversations and messages.