Improve merging of chained items #720
Conversation
| ssmlMessage = botResp.message; | ||
| plainMessage = plainMessage.replace(/<\/?[^>]+(>|$)/g, ''); // NOSONAR - javascript:S5852 - input is user controlled and we have a limit on the number of characters | ||
| } | ||
| let plainMessage = _.get(botResp, 'messages.PlainText', ''); |
There was a problem hiding this comment.
Need to confirm that the messages.Plaintext and messages.ssml do return the plaintext and ssml message separately now
|
Hi @amendlik do you have export of question you have used for testing these changes ? Have you had a chance to test against provided unit tests and functional test to see if they are passing? If not, please note that we have release 6.0.0 which has additional changes and improvements. Please refer to CHANGELOG for additional details about this release. Thank You! |
|
I don't see any updates in 6.0.0 that correspond to the improvements provided in this PR. |
|
Hi @amendlik could you please provide export of question you have used for testing these changes as requested in previous message? Also, have you had a chance test these changes with unit tests provided ? |
|
Yes, I will get those to you as soon as I'm able. |
|
@amendlik Hope all is well. Please let us know if you had a chance to export the questions you have used for testing these changes as requested in previous message. |
amendlik
force-pushed
the
merge-chained
branch
from
5a09bfa
to
e118915
Compare
|
Updated for v6.x.x and included Jest tests. |
Issue #, if available: N/A
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.