read and write updates #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstackhouse
reviewed
Sep 5, 2024
|
@mstackhouse I added the variable metadata argument to write, since this is not on the datasetjson object anymore. I can change the write function if we want to move it back to datasetjson. |
Column metasdata arguments
…e datasetjson object
…file_metadata since these aren't relevant anymore. cleaned up utils.
mstackhouse
reviewed
Sep 26, 2024
| } | ||
|
|
||
|
|
||
| set_column_metadata <- function(columns) { |
There was a problem hiding this comment.
@nicholas-masel no issue with this as is, but do we this to be a) exported, and if so, b) would we then want the first parameter back to x to be pipe-compatible.
R/variable_metadata.R
Outdated
| # x | ||
| } | ||
|
|
||
| #' #' Apply dataframe to itemData attribute |
There was a problem hiding this comment.
We should archive / delete tehis
| @@ -10,7 +10,7 @@ | |||
| #' @examples | |||
| #' # Write to character object | |||
| #' ds_json <- dataset_json(iris, "IG.IRIS", "IRIS", "Iris", iris_items) | |||
| #' js <- write_dataset_json(ds_json) | |||
| #' js <- write_dataset_json(ds_json, iris_items) | |||
There was a problem hiding this comment.
I think we can remove this again
|
|
||
| }) | ||
|
|
||
| test_that("JSON can checked from URL", { | ||
| fpath <- paste0("file://", normalizePath(test_path("testdata", "ae.json"))) | ||
| fpath <- paste0("file://", normalizePath(test_path("testdata", "invalid_dm.json"))) | ||
| expect_warning( | ||
| err <- validate_dataset_json(fpath), |
There was a problem hiding this comment.
Do you think this is valuable and worth the dependency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
develbranch until you have checked off each task.styler::style_file()to style R and Rmd filesdevtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdif the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers)pkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()