Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use vault for secrets #667

Merged
merged 3 commits into from
Nov 27, 2024
Merged

feat: use vault for secrets #667

merged 3 commits into from
Nov 27, 2024

Conversation

mc-jones
Copy link
Contributor

@mc-jones mc-jones commented Nov 19, 2024

PLATFORM-821

Prepare for using Vault

@mc-jones mc-jones requested a review from a team November 19, 2024 20:42
@mc-jones mc-jones self-assigned this Nov 19, 2024
hokusai/production.yml Outdated Show resolved Hide resolved
hokusai/production.yml Outdated Show resolved Hide resolved
@artsyjian
Copy link
Contributor

The CronJobs have to be updated as well.

Copy link
Contributor

@artsyjian artsyjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@artsyjian artsyjian merged commit a754afb into main Nov 27, 2024
4 checks passed
@artsyjian artsyjian deleted the mc-jones/feat-use-vault branch November 27, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants