fix: 天地图Marker和Popup的bug #2315
Open
fix: 天地图Marker和Popup的bug #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
December 6, 2023 22:32
lzxue
reviewed
Feb 27, 2024
packages/component/src/marker.ts
Outdated
| @@ -219,7 +220,7 @@ export default class Marker extends EventEmitter { | |||
| DOM.setTransform(element as HTMLElement, `${anchorTranslate[anchor]}`); | |||
| } | |||
| //天地图在开始缩放时触发 更新目标位置时添加过渡效果 | |||
| private updatePositionWhenZoom(ev: { map: any; center: any; zoom: any; }) { | |||
| public updatePositionWhenZoom(ev: { map: any; center: any; zoom: any; }) { | |||
| if (!this.mapsService) { | |||
There was a problem hiding this comment.
这个方法在非天地图场景，还是会报错吧，可以尝试补充一下单元测试
lzxue
approved these changes
Feb 27, 2024
added 4 commits
March 5, 2024 17:04
fix: marker和popup中计算容器坐标不正确的bug
fix: marker组件移除marker和popup方法报错的bug
# Conflicts: # packages/component/src/marker.ts # packages/component/src/popup/popup.ts
# Conflicts: # packages/component/src/marker.ts # packages/component/src/popup/popup.ts # packages/maps/src/utils/BaseMapService.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[English Template / 英文模板]
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
天地图的Marker和Popup对缩放事件的监听，写到了makrer和popup组件中，应当在具体的mapService中实现
📝 更新日志
☑️ 请求合并前的自查清单