Skip to content

refactor: add/use default params for withProgress #17513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

david-allison
Copy link
Member

Purpose / Description

Approach

The comment listed methods which were not actually affected by the PR, but it called out the fact that I was bundling in a separately scoped refactor into a PR

How Has This Been Tested?

⚠️ CI only

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Adds `withProgress { }` for Fragments with
a default 'Processing...' string

This matches the method in `Activity`
@david-allison david-allison added Needs Review cleanup Non functional change that would improve the code readability squash-merge Squash & force push by author/maintainers requested labels Nov 28, 2024
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy peasy

@mikehardy mikehardy merged commit 8214f58 into ankidroid:main Nov 28, 2024
12 checks passed
@github-actions github-actions bot removed Needs Review squash-merge Squash & force push by author/maintainers requested labels Nov 28, 2024
@github-actions github-actions bot added this to the 2.20 Release milestone Nov 28, 2024
@david-allison david-allison deleted the with-progress branch January 2, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non functional change that would improve the code readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants