Enable reflow when supported #688
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
term reflow is supported since libvterm v0.3 1. echo a long line of text 2. reduce the window width to be shorter than the line of the text 3. increase the window width to the original size old behavior: the text is truncated and not recovered new behavior: the text is reflowed
|
I'd love to get this in I guess the block for getting this merged is this?
Can you share more details on what this means @blahgeek? |
|
Would also love this feature. I reckon many folks would, they just don't know it yet :-) |
|
Sorry folks, this PR is still a draft since I encountered several cases of random crashes while running with this patch and I haven't got the time to debug yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
term reflow is supported since libvterm v0.3. (the libvterm version in the cmakelists already includes this)
how to reproduce:
old behavior: the text is truncated and not recovered
new behavior: the text is reflowed
similar to this change in neovim: neovim/neovim#21124
However, it seems that this would break per-line directory info while reflowing (I'm not very sure, I don't use that feature). Do you have any suggestions?