Add a fallback shell command #638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new `defcustom` that configures a fallback shell executable which is used if the selected shell (e.g. `vterm-shell`) is not executable. The fallback is especially useful if the `vterm` is opened on a remote host over ssh/tramp which does not have the configured `vterm-shell` installed, but the user does not want to configure a different shell for all ssh hosts, as some may have the shell in `vterm-shell` installed.
|
What if instead of a customized fallback shell you could use the same shell as used by TRAMP. If tramp works on the remote, then you could be sure that the shell is also working. Geting the TRAMP shell is just a one-liner: see: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new
defcustomthat configures a fallback shell executable which is used if the selected shell (e.g.vterm-shell) is not executable.The fallback is especially useful if the
vtermis opened on a remote host over ssh/tramp which does not have the configuredvterm-shellinstalled, but the user does not want to configure a different shell for all ssh hosts, as some may have the shell invterm-shellinstalled.This is my suggestion in response to running into #567.
I have only tested my solution on my local machine (by configuring
vterm-shellto something invalid).This change introduces breaking behavior as adding command line arguments to
vterm-shellwould have worked previously. If this is something that should be supported by vterm, my suggestion would be to add support for arguments by allowing the user to configurevterm-shellto a list or to introduce an additionaldefcustom.Edit: I added
/bin/bashas a default as it should be available pretty much everywhere. But/bin/shmight be a better choice.