Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add CI with GitHub Action #410

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[WIP] Add CI with GitHub Action #410

wants to merge 1 commit into from

Conversation

Sbozzolo
Copy link
Collaborator

@Sbozzolo Sbozzolo commented Sep 27, 2020 •
edited
Loading

With this PR, we enable CI in emacs-libvterm on Github Actions.

We run makem to lint and check the code for compliance with emacs code guidelines. We compile the module using bundled as well as system libvterm on Ubuntu 16.04 and Ubuntu 20.04.

(Thanks @zallison for start working on this!)

This was referenced Sep 27, 2020
Merged
Closed
@Sbozzolo Sbozzolo force-pushed the github_actions branch 5 times, most recently from bfdd34f to 80970de Compare September 27, 2020 15:58
@Sbozzolo
Copy link
Collaborator Author

I cannot get this to work properly, it seems that libvterm.so.0 cannot be found (see, https://github.com/Sbozzolo/emacs-libvterm/runs/1173041929 tab "Require vterm"). I don't know if, @jixiuf, you have any experience with this and you want to have a look.

@jixiuf
Copy link
Collaborator

jixiuf commented Oct 2, 2020

I cannot get this to work properly, it seems that libvterm.so.0 cannot be found (see, https://github.com/Sbozzolo/emacs-libvterm/runs/1173041929 tab "Require vterm"). I don't know if, @jixiuf, you have any experience with this and you want to have a look.

My knowledge about GitHub Actions is zero, Hope somebody else can help.

@tsuu32
Copy link

tsuu32 commented Oct 4, 2020

I cannot get this to work properly, it seems that libvterm.so.0 cannot be found (see, https://github.com/Sbozzolo/emacs-libvterm/runs/1173041929 tab "Require vterm"). I don't know if, @jixiuf, you have any experience with this and you want to have a look.

I tried https://github.com/purcell/nix-emacs-ci to install emacs-27-1 in Ubuntu 20.04 and saw same error.
So the error may be from purcell/setup-emacs@master.

@tsuu32
Copy link

tsuu32 commented Oct 7, 2020

With my limited nix knowledge I made ci.nix to build vterm-module.so which setup-emacs's emacs can load.
https://github.com/tsuu32/emacs-libvterm/runs/1222306107

@Sbozzolo Sbozzolo mentioned this pull request Oct 12, 2020
Closed
@Sbozzolo
Copy link
Collaborator Author

Sbozzolo commented Oct 12, 2020 •
edited
Loading

Thanks.

I opened an issue in purcell/setup-emacs#14.

@Sbozzolo Sbozzolo force-pushed the github_actions branch 2 times, most recently from 7fae928 to 1d66386 Compare October 26, 2020 00:03
@Sbozzolo Sbozzolo force-pushed the github_actions branch 6 times, most recently from 1d209bc to 6f96d86 Compare November 2, 2020 02:50
@jixiuf jixiuf force-pushed the master branch 2 times, most recently from 9a6dbeb to a2f2286 Compare April 14, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sbozzolo @jixiuf @tsuu32