upgrade libvterm #404
Merged
upgrade libvterm #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jixiuf
force-pushed
the
upgrade-libvterm
branch
from
6e31272
to
4aac66e
Compare
|
FYI, I tried this branch on emacs 27.1/mac catalina and haven't run into any issues. |
jixiuf
force-pushed
the
upgrade-libvterm
branch
from
4aac66e
to
c7995b8
Compare
jixiuf
force-pushed
the
upgrade-libvterm
branch
from
c7995b8
to
e4ed7c7
Compare
|
Thank you very much! That's great. I'll have a look. |
jixiuf
force-pushed
the
upgrade-libvterm
branch
from
e4ed7c7
to
fc668e3
Compare
|
I haven't looked at this in depth yet, but I think we should finish #410 first. This new PR makes the build system more fragile, so it would be great to have some form of continuous integration to run some smoke tests. |
|
Works great. No issues. Emacs 27.1 running Doom 2.0.9 on macOS Catalina 10.15.6. |
|
I can currently only get vterm to work with this branch, using a Mac OS with the latest software and updates. It also runs on both 27.1 and also on the native-comp branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#403
should fix #389
Edit: should ready to be reviewed.