Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possibility to store history in a file #377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brotzeit
Copy link
Contributor

This change allows users to track the vterm history in a file. If you intend to merge this feature I will make this right. I just don't want to spend time on it if you don't want this feature to be merged.

I would also add docs on how to add a helm source.

@brotzeit brotzeit changed the title add possibility to store history in file add possibility to store history in a file Jul 21, 2020
@Sbozzolo
Copy link
Collaborator

Can you give me some use cases? Why not just use the shell history file?

The only case I can think of in which the shell file wouldn't suffice is with remote shells.

@brotzeit
Copy link
Contributor Author

Yeah it's mostly about remote shells(I realized that I have to remove process-running-child-p). This is very helpful if you are working a lot with ssh like I do.

@Sbozzolo
Copy link
Collaborator

At the moment, I would like to focus on "infrastructure" work: bug fixes, documentation, refactoring, and so on. I believe that right now the priority is to make the code more stable and maintainable.

A while ago, I started a personal repo to add some functions to vterm: https://github.com/Sbozzolo/vterm-extra.
At the moment there are only two functions I wrote: one to quickly jump to another open vterm buffer, and the other to write more complex shell commands in a separate buffer.

I can publish this to MELPA and make it the official "contrib" repo for vterm. You could add your functions there.
We can upstream functions from vterm-extra to the main repo, once the infrastructure work is done.

What do you think?

@brotzeit
Copy link
Contributor Author

Sorry for the late reply. However I'm not sure if it's important to put optional features into an additional repo. But I will try to add the feature and open a PR in vterm-extra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants