feat: add type declarations for configs #347
Open
+101
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
requested review from
nzlaura,
eoinkelly,
lukeify,
joshmcarthur,
robotdana,
KristenEKelly,
PixeldroidAU,
simonchisnall-online,
stvmachine,
hopkincame and
justineleonard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the flat configuration system has us doing native JavaScript imports, TypeScript can now do proper type checking which means it's useful to start shipping types.
Because TypeScript requires file names to be unique (of which the file extension is not part of), I've introduced a single declaration file that holds the types for each config, rather than having a
.d.tsper config, and to ensure maximum compatibility I've defined declarations for each configuration both with and without the.jsextension.